github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-13 22:08:44 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6184] [MERGED] PM-28522: Update the Login With Device Screen #12529

New Issue
Closed
opened 2026-04-11 03:45:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:45:20 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6184
Author: @david-livefront
Created: 11/20/2025
Status: ✅ Merged
Merged: 12/1/2025
Merged by: @david-livefront

Base: main ← Head: PM-28522-login-with-device-ui

📝 Commits (1)

  • f519524 PM-28522: Update the Login With Device Screen

📊 Changes

7 files changed (+93 additions, -116 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreen.kt (+54 -68)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModel.kt (+19 -37)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreenTest.kt (+5 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModelTest.kt (+2 -5)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/field/BitwardenTextField.kt (+7 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/field/color/BitwardenTextFieldColors.kt (+3 -2)
📝 ui/src/main/res/values/strings.xml (+3 -1)

📄 Description

🎟️ Tracking

PM-28522

📔 Objective

This PR updates the LoginWithDeviceScreen, bringing it up to current standards.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6184 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 11/20/2025 **Status:** ✅ Merged **Merged:** 12/1/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-28522-login-with-device-ui` --- ### 📝 Commits (1) - [`f519524`](https://github.com/bitwarden/android/commit/f519524fb5ffcfbaa828f48ae2e3d831402a22a9) PM-28522: Update the Login With Device Screen ### 📊 Changes **7 files changed** (+93 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreen.kt` (+54 -68) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModel.kt` (+19 -37) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreenTest.kt` (+5 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModelTest.kt` (+2 -5) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/field/BitwardenTextField.kt` (+7 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/field/color/BitwardenTextFieldColors.kt` (+3 -2) 📝 `ui/src/main/res/values/strings.xml` (+3 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-28522](https://bitwarden.atlassian.net/browse/PM-28522) ## 📔 Objective This PR updates the `LoginWithDeviceScreen`, bringing it up to current standards. ## 📸 Screenshots | Before | After | | --- | --- | | <img width="350" src="https://github.com/user-attachments/assets/271c275b-f6a7-4500-95ef-1fd2e36725e6" /> | <img width="350" src="https://github.com/user-attachments/assets/46287fad-db4e-4b23-aecc-9ae82b4fadd3" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-28522]: https://bitwarden.atlassian.net/browse/PM-28522?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 03:45:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12529