github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-05 23:38:51 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6066] [MERGED] Remove night-mode icon variants where possible #12426

New Issue
Closed
opened 2026-04-11 03:42:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:42:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6066
Author: @david-livefront
Created: 10/22/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @david-livefront

Base: main ← Head: simplify-navigation-icons

📝 Commits (1)

  • 842a737 Remove night-mode icon variants where possible

📊 Changes

10 files changed (+32 additions, -133 deletions)

View changed files

📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationBarItem.kt (+7 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationRailItem.kt (+7 -1)
➖ ui/src/main/res/drawable-night/ic_generator.xml (+0 -29)
➖ ui/src/main/res/drawable-night/ic_send.xml (+0 -14)
➖ ui/src/main/res/drawable-night/ic_settings.xml (+0 -18)
➖ ui/src/main/res/drawable-night/ic_vault.xml (+0 -14)
➖ ui/src/main/res/drawable-night/ic_verification_codes.xml (+0 -18)
📝 ui/src/main/res/drawable/ic_settings.xml (+4 -8)
📝 ui/src/main/res/drawable/ic_settings_filled.xml (+14 -17)
➖ ui/src/main/res/drawable/ic_settings_solid.xml (+0 -13)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR simplifies the navigation icons by removing the night-mode variants and relying on tinting where possible.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6066 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/22/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `simplify-navigation-icons` --- ### 📝 Commits (1) - [`842a737`](https://github.com/bitwarden/android/commit/842a737fbb8f160a2415647ccb582d9be3fb92b6) Remove night-mode icon variants where possible ### 📊 Changes **10 files changed** (+32 additions, -133 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationBarItem.kt` (+7 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationRailItem.kt` (+7 -1) ➖ `ui/src/main/res/drawable-night/ic_generator.xml` (+0 -29) ➖ `ui/src/main/res/drawable-night/ic_send.xml` (+0 -14) ➖ `ui/src/main/res/drawable-night/ic_settings.xml` (+0 -18) ➖ `ui/src/main/res/drawable-night/ic_vault.xml` (+0 -14) ➖ `ui/src/main/res/drawable-night/ic_verification_codes.xml` (+0 -18) 📝 `ui/src/main/res/drawable/ic_settings.xml` (+4 -8) 📝 `ui/src/main/res/drawable/ic_settings_filled.xml` (+14 -17) ➖ `ui/src/main/res/drawable/ic_settings_solid.xml` (+0 -13) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR simplifies the navigation icons by removing the night-mode variants and relying on tinting where possible. ## 📸 Screenshots | Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/7255dcc0-ea81-4363-bd40-eb904d3fb9a3" width="300" /> | <img src="https://github.com/user-attachments/assets/f04824a2-236d-4c36-844c-93e5a008dbb9" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 03:42:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12426
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?