github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4033] [MERGED] PM-13019: Add special circumstance to navigate to the vault listing UI for TOTP code #123218

New Issue
Closed
opened 2026-06-12 01:28:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-12 01:28:09 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4033
Author: @david-livefront
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/7/2024
Merged by: @david-livefront

Base: main ← Head: PM-13019-totp-flow

📝 Commits (1)

  • 54d4552 PM-13019: Add special circumstance to navigate to the vault listing UI for TOTP code

📊 Changes

10 files changed (+201 additions, -5 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt (+9 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensions.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt (+9 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt (+14 -0)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+68 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensionsTest.kt (+33 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/base/FakeNavHostController.kt (+5 -5)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreenTest.kt (+9 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt (+37 -0)

📄 Description

🎟️ Tracking

PM-13019

📔 Objective

This PR adds the special circumstance logic to route the user to the vault listing screen for a totp code intent.

Note that the Android Manifest has not bee updated to support this flow in this PR. That will occur in a future PR.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4033 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-13019-totp-flow` --- ### 📝 Commits (1) - [`54d4552`](https://github.com/bitwarden/android/commit/54d4552dbd8432f48dba5f3df2d4a392198b53fa) PM-13019: Add special circumstance to navigate to the vault listing UI for TOTP code ### 📊 Changes **10 files changed** (+201 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt` (+9 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensions.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt` (+9 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt` (+14 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+68 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensionsTest.kt` (+33 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/base/FakeNavHostController.kt` (+5 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreenTest.kt` (+9 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt` (+37 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-13019](https://bitwarden.atlassian.net/browse/PM-13019) ## 📔 Objective This PR adds the special circumstance logic to route the user to the vault listing screen for a totp code intent. Note that the Android Manifest has not bee updated to support this flow in this PR. That will occur in a future PR. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/d730dd8a-ac1b-4256-8288-7a08200ea47b" width="300" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-13019]: https://bitwarden.atlassian.net/browse/PM-13019?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 01:28:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#123218