github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-22 12:01:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3625] [MERGED] [PM-9927] Sort order update #122886

New Issue
Closed
opened 2026-06-12 00:55:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-12 00:55:02 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3625
Author: @dseverns-livefront
Created: 7/24/2024
Status: ✅ Merged
Merged: 7/24/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-9927/sorting-special-char-at-top

📝 Commits (2)

  • f4fd4c0 PM-9927 sorted alphabetically applied to all lists in repo and now considers special chars sorted before digits and letters
  • d938d33 pr feedback, optimization

📊 Changes

10 files changed (+133 additions, -16 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/data/platform/util/SpecialCharacterStringComparator.kt (+38 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt (+10 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCollectionExtensions.kt (+8 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkFolderExtensions.kt (+13 -8)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkSendExtensions.kt (+14 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensionsTest.kt (+11 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCollectionExtensionsTest.kt (+4 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkFolderExtensionsTest.kt (+4 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkSendExtensionsTest.kt (+30 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9927

📔 Objective

Items starting with special chars should be sorted to the top of the list for vault items, this is how it exists on iOS and other clients.

📸 Screenshots

before after
9927before 9927after

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3625 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 7/24/2024 **Status:** ✅ Merged **Merged:** 7/24/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-9927/sorting-special-char-at-top` --- ### 📝 Commits (2) - [`f4fd4c0`](https://github.com/bitwarden/android/commit/f4fd4c0fc18d01d9ea69565c690e56ad90cc6d5c) PM-9927 sorted alphabetically applied to all lists in repo and now considers special chars sorted before digits and letters - [`d938d33`](https://github.com/bitwarden/android/commit/d938d3377dc44f1fc358af4e6133297baf8b4d2a) pr feedback, optimization ### 📊 Changes **10 files changed** (+133 additions, -16 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/util/SpecialCharacterStringComparator.kt` (+38 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt` (+10 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCollectionExtensions.kt` (+8 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkFolderExtensions.kt` (+13 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkSendExtensions.kt` (+14 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensionsTest.kt` (+11 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCollectionExtensionsTest.kt` (+4 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkFolderExtensionsTest.kt` (+4 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkSendExtensionsTest.kt` (+30 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-9927 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Items starting with special chars should be sorted to the top of the list for vault items, this is how it exists on iOS and other clients. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots | before | after | |--------|--------| | ![9927before](https://github.com/user-attachments/assets/a5474e05-878a-45bf-a14f-723fac3528a6) | ![9927after](https://github.com/user-attachments/assets/08ed8bde-dfed-4288-86d3-82c572b08958) | <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 00:55:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#122886