github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-11 01:33:52 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3541] [MERGED] [PM-9407] Create reusable overwrite passkey confirmation dialog #122844

New Issue
Closed
opened 2026-06-12 00:45:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-12 00:45:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3541
Author: @SaintPatrck
Created: 7/16/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-9407/overwrite-passkey-confirmation-dialog

📝 Commits (1)

  • b0a17aa [PM-9407] Create reusable overwrite passkey confirmation dialog

📊 Changes

1 file changed (+29 additions, -0 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenOverwritePasskeyConfirmationDialog.kt (+29 -0)

📄 Description

🎟️ Tracking

PM-9407

📔 Objective

Create a reusable dialog that prompts the user to confirm overwriting an existing passkey during FIDO 2 credential registration.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3541 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-9407/overwrite-passkey-confirmation-dialog` --- ### 📝 Commits (1) - [`b0a17aa`](https://github.com/bitwarden/android/commit/b0a17aa39320cc167b778ca27b2ddde7ae44b125) [PM-9407] Create reusable overwrite passkey confirmation dialog ### 📊 Changes **1 file changed** (+29 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenOverwritePasskeyConfirmationDialog.kt` (+29 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-9407 ## 📔 Objective Create a reusable dialog that prompts the user to confirm overwriting an existing passkey during FIDO 2 credential registration. ## 📸 Screenshots <img width="264" alt="image" src="https://github.com/user-attachments/assets/1f756b58-747b-4922-ab12-d0bcc0a2eb33"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 00:45:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#122844
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?