github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-24 14:28:58 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3399] [MERGED] BIT-2431 add condition to only update labelTextWidth on initial layout #122791

New Issue
Closed
opened 2026-06-12 00:41:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-12 00:41:11 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3399
Author: @dseverns-livefront
Created: 7/3/2024
Status: ✅ Merged
Merged: 7/5/2024
Merged by: @dseverns-livefront

Base: main ← Head: BIT-2431-pw-generator-field-length

📝 Commits (4)

  • df03b61 BIT-2431 add condition to only update labelTextWidth on initial layout pass
  • 89cc4e0 imports
  • 18cf643 move label to remember block
  • 70049c5 add back explicit values with comment

📊 Changes

1 file changed (+17 additions, -10 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+17 -10)

📄 Description

🎟️ Tracking

BIT-2431

📔 Objective

Fix bug where the password length field would shrink when the screen display size is zoomed all the way out.

  • able to repro original issue on Pixel 6 Pro (OS 14)
  • unable to repro on Samsung device

📸 Screenshots

https://github.com/bitwarden/android/assets/149429124/732a4de5-a8ce-4f4d-ab6d-d2b039f4bdc6

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3399 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 7/5/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `BIT-2431-pw-generator-field-length` --- ### 📝 Commits (4) - [`df03b61`](https://github.com/bitwarden/android/commit/df03b61873d68507dd2991e45baaa89debd9d1c4) BIT-2431 add condition to only update labelTextWidth on initial layout pass - [`89cc4e0`](https://github.com/bitwarden/android/commit/89cc4e07ba1dbf863528ca2c1bef7949b9316234) imports - [`18cf643`](https://github.com/bitwarden/android/commit/18cf64351358e02fed9de4002efd5878839a034a) move label to remember block - [`70049c5`](https://github.com/bitwarden/android/commit/70049c50a3552cb27ca0c28d9cbccde7e43ac595) add back explicit values with comment ### 📊 Changes **1 file changed** (+17 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+17 -10) </details> ### 📄 Description ## 🎟️ Tracking [BIT-2431](https://livefront.atlassian.net/browse/BIT-2431) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Fix bug where the password length field would shrink when the screen display size is zoomed all the way out. - able to repro original issue on Pixel 6 Pro (OS 14) - unable to repro on Samsung device <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/bitwarden/android/assets/149429124/732a4de5-a8ce-4f4d-ab6d-d2b039f4bdc6 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 00:41:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#122791