[PR #3147] [CLOSED] [PM-5153][PM-5154] iOS & Android Passkey Providers #122641

Closed
opened 2026-06-12 00:26:38 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3147
Author: @vvolkgang
Created: 4/9/2024
Status: Closed

Base: mainHead: feature/maui-migration-passkeys


📝 Commits (10+)

  • e0c7210 PM-3349 PM-3350 Migrated remaining AutomationProperties to SemanticProperties.
  • 974a571 PM-3349 PM-3350 Changed binding set for CipherViewCell so it updates accordingly
  • 363da06 PM-3349 PM-3350 Changed AccountViewCell and its binding to be directly against the ViewModel
  • 0e75f3f PM-3349 Fix for HTML Label on Android. Color hex doesn't need to be cropped anymore.
  • a31f155 PM-3350 Fix for colored html text on iOS
  • 27306fe PM-3349 PM-3350 Added the partial MAUI Community Toolkit implementation for TouchEffect. This is a temporary solution until they finalize this and add it to their nuget package.
  • e0a3c30 PM-3349 PM-3350 Changed SendViewCell and its binding to be directly against the ViewModel
  • 5712639 Merge branch 'feature/maui-migration' of https://github.com/bitwarden/mobile into feature/maui-migration
  • 5f12bb9 PM-3350 Fixed iOS Share extension lazy views loading and an issue with the avatar loading. Also discovered issue with TapGestureRecognizer not working on MAUI Embedding
  • df4d89c PM-3350 Fixed iOS Extensions navigation to several pages and improved avoiding duplicate calls to OnNavigatedTo

📊 Changes

188 files changed (+9343 additions, -618 deletions)

View changed files

📝 .gitignore (+1 -0)
lib/android/Xamarin.AndroidX.Credentials/Xamarin.AndroidX.Credentials.1.0.0.nupkg (+0 -0)
lib/android/Xamarin.AndroidX.Credentials/net8.0-android/Xamarin.AndroidX.Credentials.dll (+0 -0)
lib/android/Xamarin.AndroidX.Credentials/net8.0-android/Xamarin.AndroidX.Credentials.xml (+8 -0)
lib/android/Xamarin.AndroidX.Credentials/net8.0-android/credentials-1.2.0.aar (+0 -0)
📝 nuget.config (+1 -0)
📝 src/App/App.csproj (+3 -0)
src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+210 -0)
src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs (+178 -0)
src/App/Platforms/Android/Autofill/CredentialProviderService.cs (+168 -0)
src/App/Platforms/Android/Autofill/Fido2GetAssertionUserInterface.cs (+21 -0)
src/App/Platforms/Android/Autofill/Fido2MakeCredentialUserInterface.cs (+202 -0)
📝 src/App/Platforms/Android/MainActivity.cs (+11 -0)
📝 src/App/Platforms/Android/MainApplication.cs (+47 -2)
src/App/Platforms/Android/Resources/xml/provider.xml (+6 -0)
📝 src/App/Platforms/Android/Services/AutofillHandler.cs (+50 -4)
📝 src/App/Platforms/Android/Services/DeviceActionService.cs (+122 -15)
📝 src/App/Platforms/iOS/AppDelegate.cs (+14 -16)
📝 src/Core/Abstractions/IAutofillHandler.cs (+2 -0)
📝 src/Core/Abstractions/ICipherService.cs (+3 -4)

...and 80 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3147 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 4/9/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/maui-migration-passkeys` --- ### 📝 Commits (10+) - [`e0c7210`](https://github.com/bitwarden/android/commit/e0c721098c838ccfb875d6d1b203e1c5932729fd) PM-3349 PM-3350 Migrated remaining AutomationProperties to SemanticProperties. - [`974a571`](https://github.com/bitwarden/android/commit/974a571455ef5e86574a3012de27660f9f20ca68) PM-3349 PM-3350 Changed binding set for CipherViewCell so it updates accordingly - [`363da06`](https://github.com/bitwarden/android/commit/363da063fa7101aaa6b84383f3c8fd8540c11d8a) PM-3349 PM-3350 Changed AccountViewCell and its binding to be directly against the ViewModel - [`0e75f3f`](https://github.com/bitwarden/android/commit/0e75f3f5c8d6f30de2b18d880a70065e5f364017) PM-3349 Fix for HTML Label on Android. Color hex doesn't need to be cropped anymore. - [`a31f155`](https://github.com/bitwarden/android/commit/a31f15559ff2871a1028701ca2b496f0766aad9c) PM-3350 Fix for colored html text on iOS - [`27306fe`](https://github.com/bitwarden/android/commit/27306fe3533411e5c10b6633d61c56d71255ed16) PM-3349 PM-3350 Added the partial MAUI Community Toolkit implementation for TouchEffect. This is a temporary solution until they finalize this and add it to their nuget package. - [`e0a3c30`](https://github.com/bitwarden/android/commit/e0a3c301fbcb4e809a5b764e4d84c44e96d71280) PM-3349 PM-3350 Changed SendViewCell and its binding to be directly against the ViewModel - [`5712639`](https://github.com/bitwarden/android/commit/5712639492ceed0cf881ebafdcc935b9c5edfdc3) Merge branch 'feature/maui-migration' of https://github.com/bitwarden/mobile into feature/maui-migration - [`5f12bb9`](https://github.com/bitwarden/android/commit/5f12bb9747d15739eeea02ef2704da9705191ee9) PM-3350 Fixed iOS Share extension lazy views loading and an issue with the avatar loading. Also discovered issue with TapGestureRecognizer not working on MAUI Embedding - [`df4d89c`](https://github.com/bitwarden/android/commit/df4d89cd52a92b2f049f2a1b5c4ef8cbb79530ce) PM-3350 Fixed iOS Extensions navigation to several pages and improved avoiding duplicate calls to OnNavigatedTo ### 📊 Changes **188 files changed** (+9343 additions, -618 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `lib/android/Xamarin.AndroidX.Credentials/Xamarin.AndroidX.Credentials.1.0.0.nupkg` (+0 -0) ➕ `lib/android/Xamarin.AndroidX.Credentials/net8.0-android/Xamarin.AndroidX.Credentials.dll` (+0 -0) ➕ `lib/android/Xamarin.AndroidX.Credentials/net8.0-android/Xamarin.AndroidX.Credentials.xml` (+8 -0) ➕ `lib/android/Xamarin.AndroidX.Credentials/net8.0-android/credentials-1.2.0.aar` (+0 -0) 📝 `nuget.config` (+1 -0) 📝 `src/App/App.csproj` (+3 -0) ➕ `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+210 -0) ➕ `src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs` (+178 -0) ➕ `src/App/Platforms/Android/Autofill/CredentialProviderService.cs` (+168 -0) ➕ `src/App/Platforms/Android/Autofill/Fido2GetAssertionUserInterface.cs` (+21 -0) ➕ `src/App/Platforms/Android/Autofill/Fido2MakeCredentialUserInterface.cs` (+202 -0) 📝 `src/App/Platforms/Android/MainActivity.cs` (+11 -0) 📝 `src/App/Platforms/Android/MainApplication.cs` (+47 -2) ➕ `src/App/Platforms/Android/Resources/xml/provider.xml` (+6 -0) 📝 `src/App/Platforms/Android/Services/AutofillHandler.cs` (+50 -4) 📝 `src/App/Platforms/Android/Services/DeviceActionService.cs` (+122 -15) 📝 `src/App/Platforms/iOS/AppDelegate.cs` (+14 -16) 📝 `src/Core/Abstractions/IAutofillHandler.cs` (+2 -0) 📝 `src/Core/Abstractions/ICipherService.cs` (+3 -4) _...and 80 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 00:26:38 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#122641