github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-14 09:24:30 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3127] [MERGED] [PM-7186] Fallback to password list on exception #122632

New Issue
Closed
opened 2026-06-12 00:25:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-12 00:25:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3127
Author: @dinisvieira
Created: 4/2/2024
Status: ✅ Merged
Merged: 4/2/2024
Merged by: @vvolkgang

Base: feature/maui-migration-passkeys ← Head: bug/PM-7186-fallback-password-list-on-exception

📝 Commits (2)

  • 769ac28 PM-7186 Added fallback in case of exception that loads password list
  • 814c609 PM-7186 Added back the error message removed in last commit.

📊 Changes

2 files changed (+9 additions, -2 deletions)

View changed files

📝 src/iOS.Autofill/LoginListViewController.cs (+6 -1)
📝 src/iOS.Autofill/Models/Context.cs (+3 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When the user tries to autofill a webpage and there’s a passkey related error, they’ll see our iOS extension open with an error message. After pressing ok, the activity indicator / loading spinner isn’t removed and search won’t work, preventing users from autofilling other credentials.
We should fallback to passwords in this scenario.

Code changes

  • LoginListViewController.cs: Added fallback reload scenario
  • Context.cs: Added new boolean Flag to distinguish the fallback scenario

Screenshots

Fallback Password List if exception occurs.

Fallback password list

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3127 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 4/2/2024 **Status:** ✅ Merged **Merged:** 4/2/2024 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `feature/maui-migration-passkeys` ← **Head:** `bug/PM-7186-fallback-password-list-on-exception` --- ### 📝 Commits (2) - [`769ac28`](https://github.com/bitwarden/android/commit/769ac2808d7921f2f141ac9300b5ae002dba413e) PM-7186 Added fallback in case of exception that loads password list - [`814c609`](https://github.com/bitwarden/android/commit/814c6095460863a3df08712dd87c277c3f665b3a) PM-7186 Added back the error message removed in last commit. ### 📊 Changes **2 files changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Autofill/LoginListViewController.cs` (+6 -1) 📝 `src/iOS.Autofill/Models/Context.cs` (+3 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective When the user tries to autofill a webpage and there’s a passkey related error, they’ll see our iOS extension open with an error message. After pressing ok, the activity indicator / loading spinner isn’t removed and search won’t work, preventing users from autofilling other credentials. We should fallback to passwords in this scenario. ## Code changes * **LoginListViewController.cs:** Added fallback reload scenario * **Context.cs:** Added new boolean Flag to distinguish the fallback scenario ## Screenshots <!--Required for any UI changes. Delete if not applicable--> Fallback Password List if exception occurs. <img width="1024" alt="Fallback password list" src="https://github.com/bitwarden/mobile/assets/2824952/970e2b91-5260-478e-afd6-41a93c00aa08"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 00:25:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#122632
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?