github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-22 12:01:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3126] [CLOSED] [PM-7186] Cancel the Extension when an exception occurs #122631

New Issue
Closed
opened 2026-06-12 00:25:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-12 00:25:34 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3126
Author: @dinisvieira
Created: 3/31/2024
Status: ❌ Closed

Base: feature/maui-migration-passkeys ← Head: bug/PM-7186-avoid-extension-issues-on-error

📝 Commits (1)

  • 981d4c9 PM-7186 Cancel the Extension when an exception occurs instead of getting stuck Loading.

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/iOS.Autofill/LoginListViewController.cs (+2 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Currently the Autofill Extension can get stuck in a Loading if an exception occurss.
We also suspect there might be other errors causing our extension to get disabled by Apple and/or the ASStore to be deleted.
This is still under investigation.

Code changes

  • LoginListViewController.cs: Added Cancel after showing error to user. This way the Extension closes gracefully

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3126 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 3/31/2024 **Status:** ❌ Closed **Base:** `feature/maui-migration-passkeys` ← **Head:** `bug/PM-7186-avoid-extension-issues-on-error` --- ### 📝 Commits (1) - [`981d4c9`](https://github.com/bitwarden/android/commit/981d4c92e22683a498246ac858746088b665fa26) PM-7186 Cancel the Extension when an exception occurs instead of getting stuck Loading. ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Autofill/LoginListViewController.cs` (+2 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Currently the Autofill Extension can get stuck in a Loading if an exception occurss. We also suspect there might be other errors causing our extension to get disabled by Apple and/or the ASStore to be deleted. This is still under investigation. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **LoginListViewController.cs:** Added Cancel after showing error to user. This way the Extension closes gracefully ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 00:25:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#122631