github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 15:09:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #5857] [MERGED] Implement Zizmor workflow scanner #12239

New Issue
Closed
opened 2026-04-11 03:38:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:38:28 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5857
Author: @mandreko-bitwarden
Created: 9/10/2025
Status: ✅ Merged
Merged: 10/9/2025
Merged by: @mandreko-bitwarden

Base: main ← Head: vuln-285

📝 Commits (7)

  • f9bae7e Add Zizmor configuration and perform cleanup of existing workflows
  • 45794ae Add scan.yml changes
  • 9a6c17b Merge remote-tracking branch 'origin/main' into vuln-285
  • cf05778 Merge remote-tracking branch 'origin/main' into vuln-285
  • b8bfc4d Removed Zizmor from scan.yml since it'll be coming from bwwl
  • 874fe6f PR Feedback
  • aeb4d8e Merge remote-tracking branch 'origin/main' into vuln-285

📊 Changes

13 files changed (+369 additions, -304 deletions)

View changed files

📝 .github/workflows/build-authenticator.yml (+53 -35)
📝 .github/workflows/build.yml (+81 -66)
📝 .github/workflows/cron-sync-google-priviledged-browsers.yml (+18 -17)
📝 .github/workflows/crowdin-pull.yml (+3 -1)
📝 .github/workflows/crowdin-push.yml (+2 -0)
📝 .github/workflows/github-release.yml (+43 -36)
📝 .github/workflows/publish-github-release.yml (+1 -1)
📝 .github/workflows/publish-store.yml (+121 -111)
📝 .github/workflows/release-branch.yml (+13 -12)
📝 .github/workflows/scan.yml (+1 -1)
📝 .github/workflows/sdlc-sdk-update.yml (+20 -17)
📝 .github/workflows/test.yml (+8 -7)
➕ .github/zizmor.yml (+5 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/VULN-285

📔 Objective

Implement Zizmor workflow scanner.
Perform cleanup of existing workflows to be in compliance with Zizmor and bwwl.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5857 **Author:** [@mandreko-bitwarden](https://github.com/mandreko-bitwarden) **Created:** 9/10/2025 **Status:** ✅ Merged **Merged:** 10/9/2025 **Merged by:** [@mandreko-bitwarden](https://github.com/mandreko-bitwarden) **Base:** `main` ← **Head:** `vuln-285` --- ### 📝 Commits (7) - [`f9bae7e`](https://github.com/bitwarden/android/commit/f9bae7e3cb386fc304c72a98c9990e9a5fb38c13) Add Zizmor configuration and perform cleanup of existing workflows - [`45794ae`](https://github.com/bitwarden/android/commit/45794aed6daa9a52fda316438d11e18539671b3f) Add scan.yml changes - [`9a6c17b`](https://github.com/bitwarden/android/commit/9a6c17b6a251257ebdbf56aa1b39e1003e781abb) Merge remote-tracking branch 'origin/main' into vuln-285 - [`cf05778`](https://github.com/bitwarden/android/commit/cf0577870af57fc2206c6c99adc459296b780b9b) Merge remote-tracking branch 'origin/main' into vuln-285 - [`b8bfc4d`](https://github.com/bitwarden/android/commit/b8bfc4d3b7738620242d8254fa841d33a0eea8b6) Removed Zizmor from scan.yml since it'll be coming from bwwl - [`874fe6f`](https://github.com/bitwarden/android/commit/874fe6f7d1c4091863f31b1020cc64a0bc7919f1) PR Feedback - [`aeb4d8e`](https://github.com/bitwarden/android/commit/aeb4d8e6f9ffec9cd6be293757cbdef39001e24e) Merge remote-tracking branch 'origin/main' into vuln-285 ### 📊 Changes **13 files changed** (+369 additions, -304 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-authenticator.yml` (+53 -35) 📝 `.github/workflows/build.yml` (+81 -66) 📝 `.github/workflows/cron-sync-google-priviledged-browsers.yml` (+18 -17) 📝 `.github/workflows/crowdin-pull.yml` (+3 -1) 📝 `.github/workflows/crowdin-push.yml` (+2 -0) 📝 `.github/workflows/github-release.yml` (+43 -36) 📝 `.github/workflows/publish-github-release.yml` (+1 -1) 📝 `.github/workflows/publish-store.yml` (+121 -111) 📝 `.github/workflows/release-branch.yml` (+13 -12) 📝 `.github/workflows/scan.yml` (+1 -1) 📝 `.github/workflows/sdlc-sdk-update.yml` (+20 -17) 📝 `.github/workflows/test.yml` (+8 -7) ➕ `.github/zizmor.yml` (+5 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/VULN-285 ## 📔 Objective Implement Zizmor workflow scanner. Perform cleanup of existing workflows to be in compliance with Zizmor and bwwl. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 03:38:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12239