github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-20 20:47:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #7028] [MERGED] PM-38610: Bug: Update BitwardenBasicDialog to allow scrolling content #120971

New Issue
Closed
opened 2026-06-09 19:27:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 19:27:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/7028
Author: @david-livefront
Created: 6/5/2026
Status: ✅ Merged
Merged: 6/8/2026
Merged by: @mpbw2

Base: main ← Head: PM-38610-scrollable-basic-dialog

📝 Commits (1)

  • 79052eb PM-38610: Update BitwardenBasicDialog to allow scrolling content

📊 Changes

1 file changed (+87 additions, -37 deletions)

View changed files

📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/BitwardenBasicDialog.kt (+87 -37)

📄 Description

🎟️ Tracking

PM-38610

📔 Objective

This PR updates the BitwardenBasicDialog to be more like the BitwardenTwoButtonDialog in order to support scrolling content.

📸 Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/7028 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 6/5/2026 **Status:** ✅ Merged **Merged:** 6/8/2026 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `main` ← **Head:** `PM-38610-scrollable-basic-dialog` --- ### 📝 Commits (1) - [`79052eb`](https://github.com/bitwarden/android/commit/79052ebfac66c6a528e612cc07e077cef8ce0657) PM-38610: Update BitwardenBasicDialog to allow scrolling content ### 📊 Changes **1 file changed** (+87 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/BitwardenBasicDialog.kt` (+87 -37) </details> ### 📄 Description ## 🎟️ Tracking [PM-38610](https://bitwarden.atlassian.net/browse/PM-38610) ## 📔 Objective This PR updates the `BitwardenBasicDialog` to be more like the `BitwardenTwoButtonDialog` in order to support scrolling content. ## 📸 Screenshots | Before | After | | --- | --- | | <img width="350" src="https://github.com/user-attachments/assets/7f6c7183-a908-419d-a236-a180370c1bd4" /> | <video src="https://github.com/user-attachments/assets/090aa45e-d008-4c29-bfc0-23bcfb10ab5c" width="350" /> | [PM-38610]: https://bitwarden.atlassian.net/browse/PM-38610?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 19:27:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120971
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?