github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-13 05:12:00 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #7017] [MERGED] PM-38534: bug: Update LoginResult to use friendly error message #120961

New Issue
Closed
opened 2026-06-09 19:26:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 19:26:40 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/7017
Author: @david-livefront
Created: 6/4/2026
Status: ✅ Merged
Merged: 6/4/2026
Merged by: @david-livefront

Base: main ← Head: PM-38534-fix-generic-error-dialog

📝 Commits (1)

  • 3ad6169 PM-38534: Update LoginResult to use friendly error message

📊 Changes

8 files changed (+33 additions, -61 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+6 -19)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/LoginResult.kt (+3 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/LoginResultExtensions.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+18 -35)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/model/LoginResultExtensionsTest.kt (+2 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModelTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModelTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt (+1 -1)

📄 Description

🎟️ Tracking

PM-38534

📔 Objective

This PR updates the LoginResult to use the userFriendlyMessage for default construction. This will help improve the error messages displayed in the UI when a login fails.

📸 Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/7017 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 6/4/2026 **Status:** ✅ Merged **Merged:** 6/4/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-38534-fix-generic-error-dialog` --- ### 📝 Commits (1) - [`3ad6169`](https://github.com/bitwarden/android/commit/3ad6169dd993c46e9905e5e1952a1ba35d5ff909) PM-38534: Update LoginResult to use friendly error message ### 📊 Changes **8 files changed** (+33 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+6 -19) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/LoginResult.kt` (+3 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/LoginResultExtensions.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+18 -35) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/model/LoginResultExtensionsTest.kt` (+2 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModelTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModelTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-38534](https://bitwarden.atlassian.net/browse/PM-38534) ## 📔 Objective This PR updates the `LoginResult` to use the `userFriendlyMessage` for default construction. This will help improve the error messages displayed in the UI when a login fails. ## 📸 Screenshots | Before | After | | --- | --- | | <img width="350" src="https://github.com/user-attachments/assets/c6f9dd25-77b2-4621-a49d-af71931a6ba3" /> | <img width="350" src="https://github.com/user-attachments/assets/9a29a6a1-d445-4506-bfac-b5fce2c1deb3" /> | [PM-38534]: https://bitwarden.atlassian.net/browse/PM-38534?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 19:26:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120961