github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-21 00:33:17 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #7015] [MERGED] BWA-252: bug: Empty string totp codes should not be counted as a totp code #120959

New Issue
Closed
opened 2026-06-09 19:26:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 19:26:25 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/7015
Author: @david-livefront
Created: 6/3/2026
Status: ✅ Merged
Merged: 6/4/2026
Merged by: @david-livefront

Base: main ← Head: BWA-252-no-empty-totps

📝 Commits (1)

  • 2f89deb BWA-252: Empty string totp codes should not be counted as a totp code

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt (+3 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt (+1 -1)

📄 Description

🎟️ Tracking

BWA-252

📔 Objective

This PR filter out ciphers that have nonnull totp values but the values are blank.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/7015 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 6/3/2026 **Status:** ✅ Merged **Merged:** 6/4/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `BWA-252-no-empty-totps` --- ### 📝 Commits (1) - [`2f89deb`](https://github.com/bitwarden/android/commit/2f89debaffd0a51b2c1c01438547350d21daaac1) BWA-252: Empty string totp codes should not be counted as a totp code ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt` (+3 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [BWA-252](https://bitwarden.atlassian.net/browse/BWA-252) ## 📔 Objective This PR filter out ciphers that have nonnull totp values but the values are blank. [BWA-252]: https://bitwarden.atlassian.net/browse/BWA-252?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 19:26:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120959