github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-21 00:33:17 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #7009] [MERGED] [PM-37571] feat: Map Passport and License to SDK types #120953

New Issue
Closed
opened 2026-06-09 19:25:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 19:25:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/7009
Author: @SaintPatrck
Created: 6/2/2026
Status: ✅ Merged
Merged: 6/2/2026
Merged by: @SaintPatrck

Base: main ← Head: new-item-types/PM-37571_passport-license-upload-mapping

📝 Commits (4)

  • 03cb114 [PM-37571] fix: Complete Passport and Driver's License create and display wiring
  • 704b3f0 Use ic_id_card for Driver's License vault item icon
  • 80a73a6 Remove redundant SaveClick short-circuit tests for new item types
  • 230285a Rename VaultItem.DriversLicense to VaultItem.License

📊 Changes

10 files changed (+381 additions, -123 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+40 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt (+1 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt (+25 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensionsTest.kt (+5 -7)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+2 -103)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensionsTest.kt (+80 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt (+222 -0)
📝 network/src/testFixtures/kotlin/com/bitwarden/network/model/CipherJsonRequestUtil.kt (+4 -2)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37571

📔 Objective

Wire Passport and Driver's License through create, save, and the vault list now that their SDK mapping is available:

  • Map driversLicense/passport in the cipher upload request so the server accepts creation.
  • Allow Driver's License to save by marking the type SDK-supported and mapping it to its cipher type.
  • Render both types in the main vault list.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/7009 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 6/2/2026 **Status:** ✅ Merged **Merged:** 6/2/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `new-item-types/PM-37571_passport-license-upload-mapping` --- ### 📝 Commits (4) - [`03cb114`](https://github.com/bitwarden/android/commit/03cb114af3e84545c9e4518ea25a156da0748de5) [PM-37571] fix: Complete Passport and Driver's License create and display wiring - [`704b3f0`](https://github.com/bitwarden/android/commit/704b3f02845d8e3013f527adc7ad136f8a7ce01a) Use ic_id_card for Driver's License vault item icon - [`80a73a6`](https://github.com/bitwarden/android/commit/80a73a621318f759a8e59255908d7135fa7d84d6) Remove redundant SaveClick short-circuit tests for new item types - [`230285a`](https://github.com/bitwarden/android/commit/230285a9183cc9ba906878e18fa766c13cca3cc0) Rename VaultItem.DriversLicense to VaultItem.License ### 📊 Changes **10 files changed** (+381 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+40 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt` (+1 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt` (+25 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensionsTest.kt` (+5 -7) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+2 -103) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensionsTest.kt` (+80 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt` (+222 -0) 📝 `network/src/testFixtures/kotlin/com/bitwarden/network/model/CipherJsonRequestUtil.kt` (+4 -2) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-37571 ## 📔 Objective Wire Passport and Driver's License through create, save, and the vault list now that their SDK mapping is available: - Map `driversLicense`/`passport` in the cipher upload request so the server accepts creation. - Allow Driver's License to save by marking the type SDK-supported and mapping it to its cipher type. - Render both types in the main vault list. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 19:25:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120953