github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6962] [MERGED] [PM-37916] feat: Add titleExtraLarge typography and apply to Premium header #120908

New Issue
Closed
opened 2026-06-09 19:21:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 19:21:51 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6962
Author: @SaintPatrck
Created: 5/21/2026
Status: ✅ Merged
Merged: 5/22/2026
Merged by: @SaintPatrck

Base: main ← Head: premium-upgrade/add-title-extra-large-typography

📝 Commits (6)

  • 7a64dab PM-37916 feat: Align Premium subscription card line items with Web
  • c4a16f3 PM-37916 feat: Style Total row per design spec
  • 48b4b01 PM-37916 feat: Refine Total row and description emphasis
  • 690cb3f PM-37916 refactor: Default the common SubscriptionLineItem styles
  • 979682a PM-37916 feat: Add titleExtraLarge typography and apply to Premium header
  • ea3abed Add bodyLargeEmphasis and bodyMediumEmphasis to typography preview

📊 Changes

7 files changed (+310 additions, -56 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreen.kt (+86 -22)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanViewModel.kt (+38 -14)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreenTest.kt (+81 -9)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanViewModelTest.kt (+75 -11)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/theme/type/BitwardenTypography.kt (+2 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/theme/type/Typography.kt (+27 -0)
📝 ui/src/main/res/values/strings.xml (+1 -0)

📄 Description

🎟️ Tracking

PM-37916

📔 Objective

Design has introduced a new Title Extra-Large token (DM Sans SemiBold, 24/28) to bring the Android typography scale in line with Web. The Premium plan header is its first consumer — the existing titleLarge (19/28) was a touch undersized against the Web design.

This adds titleExtraLarge to the shared :ui typography scale (slotted above titleLarge so the data class reads in descending visual prominence, matching how displayLarge precedes displayMedium) and switches SubscriptionHeader on the Plan screen to consume it. Other screens are untouched.

📸 Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6962 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/21/2026 **Status:** ✅ Merged **Merged:** 5/22/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `premium-upgrade/add-title-extra-large-typography` --- ### 📝 Commits (6) - [`7a64dab`](https://github.com/bitwarden/android/commit/7a64dab25a4581be8d924940357f8549af4c39b9) [PM-37916] feat: Align Premium subscription card line items with Web - [`c4a16f3`](https://github.com/bitwarden/android/commit/c4a16f3fe3f01ce046d40de7f99e8f5dd8c52cb9) [PM-37916] feat: Style Total row per design spec - [`48b4b01`](https://github.com/bitwarden/android/commit/48b4b0189bedd11acabccb4627865344c31c4309) [PM-37916] feat: Refine Total row and description emphasis - [`690cb3f`](https://github.com/bitwarden/android/commit/690cb3fd16080c7f2092ad05692be11440379f74) [PM-37916] refactor: Default the common SubscriptionLineItem styles - [`979682a`](https://github.com/bitwarden/android/commit/979682ab53a720c844e122dcb675aa24b8ea7aaf) [PM-37916] feat: Add titleExtraLarge typography and apply to Premium header - [`ea3abed`](https://github.com/bitwarden/android/commit/ea3abed15231aee954f3d17b31111a8a659fac72) Add bodyLargeEmphasis and bodyMediumEmphasis to typography preview ### 📊 Changes **7 files changed** (+310 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreen.kt` (+86 -22) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanViewModel.kt` (+38 -14) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreenTest.kt` (+81 -9) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanViewModelTest.kt` (+75 -11) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/theme/type/BitwardenTypography.kt` (+2 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/theme/type/Typography.kt` (+27 -0) 📝 `ui/src/main/res/values/strings.xml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-37916](https://bitwarden.atlassian.net/browse/PM-37916) ## 📔 Objective Design has introduced a new Title Extra-Large token (DM Sans SemiBold, 24/28) to bring the Android typography scale in line with Web. The Premium plan header is its first consumer — the existing `titleLarge` (19/28) was a touch undersized against the Web design. This adds `titleExtraLarge` to the shared `:ui` typography scale (slotted above `titleLarge` so the data class reads in descending visual prominence, matching how `displayLarge` precedes `displayMedium`) and switches `SubscriptionHeader` on the Plan screen to consume it. Other screens are untouched. ## 📸 Screenshots | Before | After | |--------|--------| | <img width="365" src="https://github.com/user-attachments/assets/6b0f68eb-7345-4812-a0e0-fa5d583cad70" /> | <img width="365" src="https://github.com/user-attachments/assets/0addb854-b1f0-44f6-9a37-5b3f15113706" /> | [PM-37916]: https://bitwarden.atlassian.net/browse/PM-37916?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 19:21:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120908