github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-20 20:47:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6853] [MERGED] [PM-32806] feat: View Passport item type #120818

New Issue
Closed
opened 2026-06-09 19:11:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 19:11:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6853
Author: @SaintPatrck
Created: 4/29/2026
Status: ✅ Merged
Merged: 5/14/2026
Merged by: @SaintPatrck

Base: main ← Head: new-item-types/PM-32806_passport

📝 Commits (7)

  • 506dcda PM-32806 feat: View Passport item type
  • c8293f0 Add inline copy affordance for National identification number
  • d68f01d Keep Passport field names aligned with the SDK and server
  • ec79645 Drop placeholder visibility actions from Passport View
  • 545bf13 Add inline copy affordance for Passport given name and surname
  • 8f9c11c Introduce rememberVaultPassportItemTypeHandlers helper
  • e33e9ef Add Passport icon, screen tests, and CipherViewExtensions coverage

📊 Changes

17 files changed (+1656 additions, -24 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+3 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt (+4 -1)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemPassportContent.kt (+554 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt (+9 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+146 -2)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultPassportItemTypeHandlers.kt (+71 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt (+14 -11)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensionsTest.kt (+92 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+302 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt (+293 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultPassportItemTypeHandlersTest.kt (+56 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensionsTest.kt (+95 -0)
➕ ui/src/main/res/drawable/ic_passport.xml (+9 -0)
📝 ui/src/main/res/values/strings.xml (+5 -0)

📄 Description

🎟️ Tracking

📔 Objective

Add the View screen for the Passport item type, gated behind pm-32009-new-item-types.

📸 Screenshots

Figma Actual (Preview)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6853 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/29/2026 **Status:** ✅ Merged **Merged:** 5/14/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `new-item-types/PM-32806_passport` --- ### 📝 Commits (7) - [`506dcda`](https://github.com/bitwarden/android/commit/506dcda4f479a197e1f95073720c1655e4466d56) [PM-32806] feat: View Passport item type - [`c8293f0`](https://github.com/bitwarden/android/commit/c8293f0e462bdda46591686410e7e7239f878323) Add inline copy affordance for National identification number - [`d68f01d`](https://github.com/bitwarden/android/commit/d68f01dbecaed2f943d38d90222a9974c39925c0) Keep Passport field names aligned with the SDK and server - [`ec79645`](https://github.com/bitwarden/android/commit/ec79645835ddddfe4f94e7b41e49fdbf50d91bcc) Drop placeholder visibility actions from Passport View - [`545bf13`](https://github.com/bitwarden/android/commit/545bf133f32edd84cf6e9be0fef9254fa5e34f49) Add inline copy affordance for Passport given name and surname - [`8f9c11c`](https://github.com/bitwarden/android/commit/8f9c11c3ba2a94b867a21a342c856dc2fe321c7a) Introduce rememberVaultPassportItemTypeHandlers helper - [`e33e9ef`](https://github.com/bitwarden/android/commit/e33e9efe6260921743bb9a27e988c00fbcb0b1c3) Add Passport icon, screen tests, and CipherViewExtensions coverage ### 📊 Changes **17 files changed** (+1656 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+3 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt` (+4 -1) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemPassportContent.kt` (+554 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt` (+9 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+146 -2) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultPassportItemTypeHandlers.kt` (+71 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt` (+14 -11) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensionsTest.kt` (+92 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+302 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt` (+293 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultPassportItemTypeHandlersTest.kt` (+56 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensionsTest.kt` (+95 -0) ➕ `ui/src/main/res/drawable/ic_passport.xml` (+9 -0) 📝 `ui/src/main/res/values/strings.xml` (+5 -0) </details> ### 📄 Description ## 🎟️ Tracking - Jira: [PM-32806](https://bitwarden.atlassian.net/browse/PM-32806) ## 📔 Objective Add the View screen for the Passport item type, gated behind `pm-32009-new-item-types`. ## 📸 Screenshots | Figma | Actual (Preview) | |--------|--------| | <img width="365" src="https://github.com/user-attachments/assets/9bc01d25-5a52-4c3e-82b6-f8f87c2f60af" /> | <img width="365" src="https://github.com/user-attachments/assets/aa915e58-1639-4bb4-b2fc-e1ca1ad9ef24" /> | [PM-32806]: https://bitwarden.atlassian.net/browse/PM-32806?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 19:11:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120818
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?