github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-15 08:34:16 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6752] [MERGED] PM-34499: bug: Add appropriate external link callouts for attachments #120741

New Issue
Closed
opened 2026-06-09 19:03:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 19:03:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6752
Author: @david-livefront
Created: 4/1/2026
Status: ✅ Merged
Merged: 4/1/2026
Merged by: @david-livefront

Base: main ← Head: PM-34499-attachment-external-link

📝 Commits (1)

  • a322cc4 PM-34499: Add appropriate external link callouts for attachments

📊 Changes

5 files changed (+34 additions, -6 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/preview/PreviewAttachmentScreen.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemAttachment.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/preview/PreviewAttachmentScreenTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+12 -4)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenStandardIconButton.kt (+18 -1)

📄 Description

🎟️ Tracking

PM-34499

📔 Objective

This PR adds accessibility callouts for external links in the Attachments UI.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6752 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/1/2026 **Status:** ✅ Merged **Merged:** 4/1/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-34499-attachment-external-link` --- ### 📝 Commits (1) - [`a322cc4`](https://github.com/bitwarden/android/commit/a322cc474694c0b72fa6986b5518d6c6228fdd13) PM-34499: Add appropriate external link callouts for attachments ### 📊 Changes **5 files changed** (+34 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/preview/PreviewAttachmentScreen.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemAttachment.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/preview/PreviewAttachmentScreenTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+12 -4) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenStandardIconButton.kt` (+18 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-34499](https://bitwarden.atlassian.net/browse/PM-34499) ## 📔 Objective This PR adds accessibility callouts for external links in the Attachments UI. [PM-34499]: https://bitwarden.atlassian.net/browse/PM-34499?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 19:03:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120741