github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-14 23:51:04 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6360] [MERGED] [PM-30823] ci: Fix BWA Play Store publishing for rc cherry picks and update upload step names #120416

New Issue
Closed
opened 2026-06-09 18:24:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 18:24:21 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6360
Author: @vvolkgang
Created: 1/14/2026
Status: ✅ Merged
Merged: 1/15/2026
Merged by: @vvolkgang

Base: main ← Head: vvolkgang/fix-bwa-publishing

📝 Commits (8)

  • 153556a Update github artifacts upload step names in build workflows, differentiating them from store publishing steps
  • b1a588a Fix BWA store publishing after merging cherrypicks
  • fd77145 Consolidate firebase and playstore distribution logic in top level env vars
  • cc938ed Add apk / aab checks to firebase setup and playstore verification steps
  • a09ff7f Align bwa build workflow input defaults with bwpm
  • 5865173 Add aab check to firebase setup in bwa build workflow
  • ecb42a1 Refactor publishing and distribution step names
  • 9fb48e4 Add new env vars to steps missing it

📊 Changes

2 files changed (+45 additions, -43 deletions)

View changed files

📝 .github/workflows/build-authenticator.yml (+16 -16)
📝 .github/workflows/build.yml (+29 -27)

📄 Description

🎟️ Tracking

PM-30823

📔 Objective

Address @mpbw2 findings handling the recent release:

  1. Fix - when PRs were merged to release branches builds weren't published to PlayStore.
  2. Fix - firebase setup and playstore creds verification steps running when the publishing steps are skipped
  3. Refactor - consolidate firebase / playstore publishing flags as environment vars.
  4. Clarify "Upload" steps are uploading artifacts to the github run, addressing them being confused with steps that upload to Firebase / PlayStore.
  5. Align BWA build workflow defaults with BWPM.

Test Runs:

  1. BWPM - https://github.com/bitwarden/android/actions/runs/21007063766
  2. BWA - https://github.com/bitwarden/android/actions/runs/21007056374

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6360 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 1/14/2026 **Status:** ✅ Merged **Merged:** 1/15/2026 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `vvolkgang/fix-bwa-publishing` --- ### 📝 Commits (8) - [`153556a`](https://github.com/bitwarden/android/commit/153556a2f7407100efbdd2ab7f12f685d282826d) Update github artifacts upload step names in build workflows, differentiating them from store publishing steps - [`b1a588a`](https://github.com/bitwarden/android/commit/b1a588a945b8e79728a1532bbcb2ebbd1e7fd740) Fix BWA store publishing after merging cherrypicks - [`fd77145`](https://github.com/bitwarden/android/commit/fd77145b60d5648ef8fc0d0ebe7f58c98646c4f6) Consolidate firebase and playstore distribution logic in top level env vars - [`cc938ed`](https://github.com/bitwarden/android/commit/cc938eda2bbc8e646936dfb8e13020b570ad3292) Add apk / aab checks to firebase setup and playstore verification steps - [`a09ff7f`](https://github.com/bitwarden/android/commit/a09ff7fc6515682f005c03d0cefa1427aff702f1) Align bwa build workflow input defaults with bwpm - [`5865173`](https://github.com/bitwarden/android/commit/5865173f2c2c76eec18f5dd941dea9d74cb7fab4) Add aab check to firebase setup in bwa build workflow - [`ecb42a1`](https://github.com/bitwarden/android/commit/ecb42a105a3aa065e0ec6790f9b2be0296b71eb0) Refactor publishing and distribution step names - [`9fb48e4`](https://github.com/bitwarden/android/commit/9fb48e4cc8ae6d70cb3e9540f1c0e0a6a74a97e1) Add new env vars to steps missing it ### 📊 Changes **2 files changed** (+45 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-authenticator.yml` (+16 -16) 📝 `.github/workflows/build.yml` (+29 -27) </details> ### 📄 Description ## 🎟️ Tracking PM-30823 ## 📔 Objective Address @mpbw2 findings handling the recent release: 1. Fix - when PRs were merged to release branches builds weren't published to PlayStore. 2. Fix - firebase setup and playstore creds verification steps running when the publishing steps are skipped 3. Refactor - consolidate firebase / playstore publishing flags as environment vars. 4. Clarify "Upload" steps are uploading artifacts to the github run, addressing them being confused with steps that upload to Firebase / PlayStore. 5. Align BWA build workflow defaults with BWPM. Test Runs: 1. BWPM - https://github.com/bitwarden/android/actions/runs/21007063766 2. BWA - https://github.com/bitwarden/android/actions/runs/21007056374 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 18:24:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120416