github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 15:09:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #5937] [MERGED] [PM-20977] Handle new sdk exception type. #120064

New Issue
Closed
opened 2026-06-09 17:47:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 17:47:27 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5937
Author: @andrebispo5
Created: 9/25/2025
Status: ✅ Merged
Merged: 9/26/2025
Merged by: @andrebispo5

Base: main ← Head: pm-20977/sdk_error_code

📝 Commits (2)

  • 6edd872 [PM-20977] Handle new sdk exception type.
  • 0c174db [PM-20977] Add Crypto error handling and tests.

📊 Changes

2 files changed (+60 additions, -9 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+9 -5)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt (+51 -4)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20977

📔 Objective

Update app to use new error type from sdk:
https://github.com/bitwarden/android/pull/5922
https://bitwarden.atlassian.net/browse/PM-23785

Error handling improvements

  • Catch BitwardenException.DeriveKeyConnector and check if the underlying exception is DeriveKeyConnectorException.WrongPassword, returning a dedicated error result for wrong passwords.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5937 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/25/2025 **Status:** ✅ Merged **Merged:** 9/26/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-20977/sdk_error_code` --- ### 📝 Commits (2) - [`6edd872`](https://github.com/bitwarden/android/commit/6edd87200aaed55373a4a821b9576e7dead75a1e) [PM-20977] Handle new sdk exception type. - [`0c174db`](https://github.com/bitwarden/android/commit/0c174db6fab06b57c678d5b51b9f3f6abb7cf1f4) [PM-20977] Add Crypto error handling and tests. ### 📊 Changes **2 files changed** (+60 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+9 -5) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt` (+51 -4) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-20977 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Update app to use new error type from sdk: https://github.com/bitwarden/android/pull/5922 https://bitwarden.atlassian.net/browse/PM-23785 #### Error handling improvements * Catch `BitwardenException.DeriveKeyConnector` and check if the underlying exception is `DeriveKeyConnectorException.WrongPassword`, returning a dedicated error result for wrong passwords. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 17:47:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#120064