github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-13 05:12:00 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3012] [MERGED] [PM-6291] Fix Device Login Pending Requests screen not displaying anything #117854

New Issue
Closed
opened 2026-06-09 13:26:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-09 13:26:07 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3012
Author: @dinisvieira
Created: 2/18/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @dinisvieira

Base: main ← Head: feature/PM-6291-fix-pending-requests-not-visible

📝 Commits (2)

  • e77b7cd PM-6291 Changed Passwordless Request Login Page Layout structure so that it can display properly
  • 738da6b PM-6291 Additional changes to allow iOS to show the correct with on the collectionview items

📊 Changes

3 files changed (+77 additions, -60 deletions)

View changed files

📝 src/Core/Pages/Settings/LoginPasswordlessRequestsListPage.xaml (+61 -56)
📝 src/Core/Pages/Settings/LoginPasswordlessRequestsListPage.xaml.cs (+15 -3)
📝 src/Core/Pages/Settings/LoginPasswordlessRequestsListViewModel.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The Device Login Pending Requests screen is not displaying anything.
If there are no items to show sometimes rotating the device would make the "No pending requests" message and image to appear which hints at a layout/arrange issue. When there are items to show the page never seems to load anything.

Code changes

Notes:

  • As I started fixing issues with this screen I noticed there are multiple ones and they all seem to be related with the RefreshView not "layouting" itself properly when the CollectionView items change. I tried using InvalidateArrange() on several elements of the layout tree but it doesn't seem to help either.

  • The changes that I found avoided this issue were having the layout directly on the Page at compile time instead of adding it to the ContentView in runtime and also switching the StackLayout's to Grids and that seems to "force" the RefreshView to take full width/height and allow the inner CollectionView to be able to update itself (at least on Android)

  • For iOS I also had to use a background color on a full screen grid that has the activity indicator and hides the refreshview below because using IsVisible on the RefreshView "layout tree" causes issues with the layout in iOS. (in practice when making the refreshview visible the size doesn't seem to be calculating properly on iOS and having it there "behind" the activity indicator grid avoids this issue.

  • LoginPasswordlessRequestsListPage.xaml: Moved the page xaml from the Resources to the Content of the page directly. Changed StackLayout's to Grids and added a new Grid for showing the ActivityIndicator

  • LoginPasswordlessRequestsListPage.xaml.cs: Changes to no longer use the BaseContentPage SetActivityIndicator() and LoadOnAppearedAsync()

  • LoginPasswordlessRequestsListViewModel.cs: Minor change to use MainThread instead of the old Device

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3012 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/18/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `feature/PM-6291-fix-pending-requests-not-visible` --- ### 📝 Commits (2) - [`e77b7cd`](https://github.com/bitwarden/android/commit/e77b7cd4d9d917e24f3bdb5a195da7298935ae59) PM-6291 Changed Passwordless Request Login Page Layout structure so that it can display properly - [`738da6b`](https://github.com/bitwarden/android/commit/738da6b415b3c4b977f0e07a52da96d4fcf8b8b1) PM-6291 Additional changes to allow iOS to show the correct with on the collectionview items ### 📊 Changes **3 files changed** (+77 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Settings/LoginPasswordlessRequestsListPage.xaml` (+61 -56) 📝 `src/Core/Pages/Settings/LoginPasswordlessRequestsListPage.xaml.cs` (+15 -3) 📝 `src/Core/Pages/Settings/LoginPasswordlessRequestsListViewModel.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective The Device Login Pending Requests screen is not displaying anything. If there are no items to show sometimes rotating the device would make the "No pending requests" message and image to appear which hints at a layout/arrange issue. When there are items to show the page never seems to load anything. ## Code changes Notes: * As I started fixing issues with this screen I noticed there are multiple ones and they all seem to be related with the `RefreshView` not "layouting" itself properly when the `CollectionView` items change. I tried using `InvalidateArrange()` on several elements of the layout tree but it doesn't seem to help either. * The changes that I found avoided this issue were having the layout directly on the Page at compile time instead of adding it to the `ContentView` in runtime and also switching the StackLayout's to Grids and that seems to "force" the `RefreshView` to take full width/height and allow the inner `CollectionView` to be able to update itself (at least on Android) * For iOS I also had to use a background color on a full screen grid that has the activity indicator and hides the refreshview below because using `IsVisible` on the `RefreshView` "layout tree" causes issues with the layout in iOS. (in practice when making the refreshview visible the size doesn't seem to be calculating properly on iOS and having it there "behind" the activity indicator grid avoids this issue. * **LoginPasswordlessRequestsListPage.xaml:** Moved the page xaml from the `Resources` to the Content of the page directly. Changed StackLayout's to Grids and added a new Grid for showing the `ActivityIndicator` * **LoginPasswordlessRequestsListPage.xaml.cs:** Changes to no longer use the `BaseContentPage` `SetActivityIndicator()` and `LoadOnAppearedAsync()` * **LoginPasswordlessRequestsListViewModel.cs:** Minor change to use `MainThread` instead of the old `Device` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-09 13:26:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#117854