github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #7011] [MERGED] [PM-37571] chore: Remove unused isSdkSupported guard #114098

New Issue
Closed
opened 2026-06-06 13:52:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 13:52:26 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/7011
Author: @SaintPatrck
Created: 6/3/2026
Status: ✅ Merged
Merged: 6/3/2026
Merged by: @SaintPatrck

Base: main ← Head: new-item-types/PM-37571_remove-issdksupported

📝 Commits (1)

  • e5827ed [PM-37571] chore: Remove unused isSdkSupported guard

📊 Changes

2 files changed (+3 additions, -19 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+0 -13)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+3 -6)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37571

📔 Objective

Remove the isSdkSupported property and the save-path guard it fed. Now that every item type has SDK support, the property is always true, so the guard that blocked saving unsupported types is unreachable dead code.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/7011 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 6/3/2026 **Status:** ✅ Merged **Merged:** 6/3/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `new-item-types/PM-37571_remove-issdksupported` --- ### 📝 Commits (1) - [`e5827ed`](https://github.com/bitwarden/android/commit/e5827ed55963d049f27f7264556288aa22b4b12f) [PM-37571] chore: Remove unused isSdkSupported guard ### 📊 Changes **2 files changed** (+3 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+0 -13) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+3 -6) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-37571 ## 📔 Objective Remove the `isSdkSupported` property and the save-path guard it fed. Now that every item type has SDK support, the property is always `true`, so the guard that blocked saving unsupported types is unreachable dead code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 13:52:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#114098