github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-13 22:08:44 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6980] [MERGED] [PM-37804] fix: Drop redundant Stripe checkout confirmation on Upgrade Now #114068

New Issue
Closed
opened 2026-06-06 13:49:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 13:49:56 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6980
Author: @SaintPatrck
Created: 5/26/2026
Status: ✅ Merged
Merged: 5/28/2026
Merged by: @SaintPatrck

Base: main ← Head: premium-upgrade/revert-redundant-stripe-checkout-dialog

📝 Commits (1)

  • 8bd96c7 fix: Drop redundant Stripe checkout confirmation on Upgrade Now

📊 Changes

2 files changed (+5 additions, -76 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreen.kt (+1 -20)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreenTest.kt (+4 -56)

📄 Description

🎟️ Tracking

PM-37804
Follow-up to #6958.

📔 Objective

The Upgrade Now CTA on the free Premium plan screen already shows the Stripe checkout disclosure directly beneath the button. The confirmation dialog added in #6958 repeated that exact copy verbatim, costing an extra tap without conveying any new information.

This change removes the dialog so the footer is the single, in-context disclosure for that CTA. The Cancel Premium and Manage Plan confirmation dialogs are unaffected; neither has accompanying footer copy, so their dialogs still earn their place.

📸 Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6980 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/26/2026 **Status:** ✅ Merged **Merged:** 5/28/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `premium-upgrade/revert-redundant-stripe-checkout-dialog` --- ### 📝 Commits (1) - [`8bd96c7`](https://github.com/bitwarden/android/commit/8bd96c7023ecb6cf4bac39f703f831b44e4d035c) fix: Drop redundant Stripe checkout confirmation on Upgrade Now ### 📊 Changes **2 files changed** (+5 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreen.kt` (+1 -20) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreenTest.kt` (+4 -56) </details> ### 📄 Description ## 🎟️ Tracking PM-37804 Follow-up to #6958. ## 📔 Objective The Upgrade Now CTA on the free Premium plan screen already shows the Stripe checkout disclosure directly beneath the button. The confirmation dialog added in #6958 repeated that exact copy verbatim, costing an extra tap without conveying any new information. This change removes the dialog so the footer is the single, in-context disclosure for that CTA. The Cancel Premium and Manage Plan confirmation dialogs are unaffected; neither has accompanying footer copy, so their dialogs still earn their place. ## 📸 Screenshots | Before | After | |--------|--------| | <video src="https://github.com/user-attachments/assets/495f4f64-3b22-405c-94b5-4c3e073a1df0" />| <video src="https://github.com/user-attachments/assets/7fab56ad-2048-41cc-90bf-adfecd83ce58" /> | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 13:49:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#114068