github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #6979] [MERGED] PM-38140 Feat: SDK policy filters #114067

New Issue
Closed
opened 2026-06-06 13:49:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 13:49:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6979
Author: @david-livefront
Created: 5/26/2026
Status: ✅ Merged
Merged: 5/27/2026
Merged by: @david-livefront

Base: main ← Head: PM-38140-sdk-policy-filters

📝 Commits (4)

  • 7c6e56b Update SdkClientManager to support simple synchronous functions
  • 21c3642 Expose filterPolicies function via AuthSdkSource
  • 2f51311 Add PoliciesInAcceptedState feature flag
  • 74936b6 Update PolicyManager to use the SDK filterPolicies functionality

📊 Changes

20 files changed (+628 additions, -101 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSource.kt (+12 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt (+15 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/sdk/BaseSdkSource.kt (+5 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerImpl.kt (+97 -64)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManager.kt (+7 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerImpl.kt (+15 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+7 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/ScopedVaultSdkSourceImpl.kt (+1 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkOrganizationExtensions.kt (+48 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt (+38 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerTest.kt (+252 -32)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerTest.kt (+2 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/OrganizationUserPolicyContextUtil.kt (+27 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkOrganizationExtensionsTest.kt (+75 -0)
📝 core/src/main/kotlin/com/bitwarden/core/data/manager/model/FlagKey.kt (+9 -0)
📝 core/src/test/kotlin/com/bitwarden/core/data/manager/model/FlagKeyTest.kt (+5 -0)
📝 network/src/main/kotlin/com/bitwarden/network/model/OrganizationStatusType.kt (+6 -0)
📝 network/src/main/kotlin/com/bitwarden/network/model/SyncResponseJson.kt (+3 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/debug/FeatureFlagListItems.kt (+3 -4)
📝 ui/src/main/res/values/strings_non_localized.xml (+1 -0)

📄 Description

🎟️ Tracking

PM-38140

📔 Objective

This PR updates the PolicyManager to utilized the SDK when filtering out policies.

Main changes:

  • Added a new globalClient that can be accessed synchronously.
  • Implemented the SDK filterPolicies function utilizing the globalClient
  • Updated the PoliocyManager to utilized these new tools.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6979 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 5/26/2026 **Status:** ✅ Merged **Merged:** 5/27/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-38140-sdk-policy-filters` --- ### 📝 Commits (4) - [`7c6e56b`](https://github.com/bitwarden/android/commit/7c6e56b7ba643e0fca90065be37212003eb3135b) Update SdkClientManager to support simple synchronous functions - [`21c3642`](https://github.com/bitwarden/android/commit/21c364244f1158181990d644fd057a812d8c8c5d) Expose filterPolicies function via AuthSdkSource - [`2f51311`](https://github.com/bitwarden/android/commit/2f51311889409ac5bfe8d44aecf7773498102c48) Add PoliciesInAcceptedState feature flag - [`74936b6`](https://github.com/bitwarden/android/commit/74936b6f21b2ed71c6b00a81a884edfe72262d88) Update PolicyManager to use the SDK filterPolicies functionality ### 📊 Changes **20 files changed** (+628 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSource.kt` (+12 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt` (+15 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/sdk/BaseSdkSource.kt` (+5 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerImpl.kt` (+97 -64) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManager.kt` (+7 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerImpl.kt` (+15 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+7 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/ScopedVaultSdkSourceImpl.kt` (+1 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkOrganizationExtensions.kt` (+48 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt` (+38 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerTest.kt` (+252 -32) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerTest.kt` (+2 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/OrganizationUserPolicyContextUtil.kt` (+27 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkOrganizationExtensionsTest.kt` (+75 -0) 📝 `core/src/main/kotlin/com/bitwarden/core/data/manager/model/FlagKey.kt` (+9 -0) 📝 `core/src/test/kotlin/com/bitwarden/core/data/manager/model/FlagKeyTest.kt` (+5 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/model/OrganizationStatusType.kt` (+6 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/model/SyncResponseJson.kt` (+3 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/debug/FeatureFlagListItems.kt` (+3 -4) 📝 `ui/src/main/res/values/strings_non_localized.xml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-38140](https://bitwarden.atlassian.net/browse/PM-38140) ## 📔 Objective This PR updates the `PolicyManager` to utilized the SDK when filtering out policies. Main changes: * Added a new `globalClient` that can be accessed synchronously. * Implemented the SDK `filterPolicies` function utilizing the `globalClient` * Updated the `PoliocyManager` to utilized these new tools. [PM-38140]: https://bitwarden.atlassian.net/browse/PM-38140?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 13:49:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#114067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?