github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 08:36:09 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #6968] [MERGED] [PM-37282] feat: Add Upgrade to Premium CTA to File Send dialog #114057

New Issue
Closed
opened 2026-06-06 13:48:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 13:48:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6968
Author: @SaintPatrck
Created: 5/22/2026
Status: ✅ Merged
Merged: 5/26/2026
Merged by: @SaintPatrck

Base: main ← Head: PM-37282/file-send-upgrade-cta-dialog

📝 Commits (1)

📊 Changes

10 files changed (+227 additions, -16 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendGraphNavigation.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendNavigation.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreen.kt (+19 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt (+30 -6)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+12 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+18 -8)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreenTest.kt (+55 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModelTest.kt (+27 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+36 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+27 -1)

📄 Description

🎟️ Tracking

PM-37282

📔 Objective

Replace the free-tier "File Sends require Premium" dead-end "Okay" dialog with a two-button "Cancel" / "Upgrade to Premium" CTA at both real entry points — the Send tab "+" FAB and the Send file item-listing screen — matching how other premium gates in the app surface an in-line upgrade path. Gated on PremiumStateManager.isInAppUpgradeAvailable() so the original single-button dialog still appears when the in-app upgrade path isn't actually offered.

📸 Screenshots

Figma Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6968 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/22/2026 **Status:** ✅ Merged **Merged:** 5/26/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-37282/file-send-upgrade-cta-dialog` --- ### 📝 Commits (1) - [`f0b8ce7`](https://github.com/bitwarden/android/commit/f0b8ce72b718e81c082d2aed63747e647bf7d9af) [PM-37282] feat: Add Upgrade to Premium CTA to File Send dialog ### 📊 Changes **10 files changed** (+227 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendGraphNavigation.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendNavigation.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreen.kt` (+19 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt` (+30 -6) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+12 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+18 -8) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreenTest.kt` (+55 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModelTest.kt` (+27 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+36 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+27 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-37282](https://bitwarden.atlassian.net/browse/PM-37282) ## 📔 Objective Replace the free-tier "File Sends require Premium" dead-end "Okay" dialog with a two-button "Cancel" / "Upgrade to Premium" CTA at both real entry points — the Send tab "+" FAB and the Send file item-listing screen — matching how other premium gates in the app surface an in-line upgrade path. Gated on `PremiumStateManager.isInAppUpgradeAvailable()` so the original single-button dialog still appears when the in-app upgrade path isn't actually offered. ## 📸 Screenshots | Figma | Before | After | |--------|--------|--------| | <img width="365" src="https://github.com/user-attachments/assets/b6fea13c-7dd1-461d-aa07-34eba3a6eb1b" /> | <img width="365" src="https://github.com/user-attachments/assets/9e0986cb-9f38-4bc0-a56b-69c7d9f352ad" /> | <img width="365" src="https://github.com/user-attachments/assets/ce6a2ff1-b0a0-4d96-8156-3df9b7445210" /> | [PM-37282]: https://bitwarden.atlassian.net/browse/PM-37282?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 13:48:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#114057
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?