github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-20 12:38:11 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6908] [MERGED] [PM-32808] feat: Add Add/Edit support for Driver's License item type #114004

New Issue
Closed
opened 2026-06-06 13:42:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 13:42:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6908
Author: @SaintPatrck
Created: 5/11/2026
Status: ✅ Merged
Merged: 5/13/2026
Merged by: @SaintPatrck

Base: main ← Head: new-item-types/PM-32808_drivers-license-add-edit

📝 Commits (2)

  • b2c0470 PM-32808 feat: Add/Edit support for License item type
  • 890aad2 Cover License section wiring in VaultAddEditScreenTest

📊 Changes

10 files changed (+719 additions, -19 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+8 -1)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLicenseItems.kt (+186 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+6 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+107 -4)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLicenseTypeHandlers.kt (+100 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+148 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+159 -8)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt (+1 -1)
📝 ui/src/main/res/values/strings.xml (+3 -4)

📄 Description

🎟️ Tracking

  • PM-32808 — Driver's License item type
  • Parent epic: PM-32009 — New Item Types
  • Parent PR: #6852 — Driver's License View

📔 Objective

Adds the Add/Edit form for the Driver's License cipher type so users can create new licenses and edit existing ones. Renders editable fields for first / middle / last name, license number (sensitive with show/hide), issuing country, issuing state / province, issuing authority, and license class. Date fields (date of birth, issue date, expiration date) appear as read-only chevron rows pending the native Material date-picker integration, which is tracked separately.

📸 Screenshots

Figma Actual
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6908 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/11/2026 **Status:** ✅ Merged **Merged:** 5/13/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `new-item-types/PM-32808_drivers-license-add-edit` --- ### 📝 Commits (2) - [`b2c0470`](https://github.com/bitwarden/android/commit/b2c04706da51daca8523ffe45e286d2876b96b7a) [PM-32808] feat: Add/Edit support for License item type - [`890aad2`](https://github.com/bitwarden/android/commit/890aad28e56026e1d31c466031e0711214ee142d) Cover License section wiring in VaultAddEditScreenTest ### 📊 Changes **10 files changed** (+719 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+8 -1) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLicenseItems.kt` (+186 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+6 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+107 -4) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLicenseTypeHandlers.kt` (+100 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+148 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+159 -8) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt` (+1 -1) 📝 `ui/src/main/res/values/strings.xml` (+3 -4) </details> ### 📄 Description ## 🎟️ Tracking - [PM-32808](https://bitwarden.atlassian.net/browse/PM-32808) — Driver's License item type - Parent epic: [PM-32009](https://bitwarden.atlassian.net/browse/PM-32009) — New Item Types - Parent PR: #6852 — Driver's License View ## 📔 Objective Adds the Add/Edit form for the Driver's License cipher type so users can create new licenses and edit existing ones. Renders editable fields for first / middle / last name, license number (sensitive with show/hide), issuing country, issuing state / province, issuing authority, and license class. Date fields (date of birth, issue date, expiration date) appear as read-only chevron rows pending the native Material date-picker integration, which is tracked separately. ## 📸 Screenshots | Figma | Actual | |--------|--------| | <img width="365" src="https://github.com/user-attachments/assets/5b04b74c-056f-468e-b8d2-46eaa899fe64" /> | <img width="365" src="https://github.com/user-attachments/assets/8c3678b9-6af2-4d78-b193-eb3775d13364" /> | | <img width="365" src="https://github.com/user-attachments/assets/496cdb46-80fb-40e8-bd0e-43c6544d34fc" /> | <img width="429" height="890" alt="image" src="https://github.com/user-attachments/assets/7be00422-f5a7-4ca9-9da5-e0f4cd703395" /> | [PM-32808]: https://bitwarden.atlassian.net/browse/PM-32808?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-32009]: https://bitwarden.atlassian.net/browse/PM-32009?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 13:42:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#114004
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?