github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-16 23:25:17 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6896] [MERGED] Chore: Remove Retrofit dependency from app module #113995

New Issue
Closed
opened 2026-06-06 13:41:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 13:41:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6896
Author: @david-livefront
Created: 5/8/2026
Status: ✅ Merged
Merged: 5/12/2026
Merged by: @david-livefront

Base: main ← Head: remove-retrofit-dependency

📝 Commits (1)

  • 9717423 Remove Retrofit dependency from app module

📊 Changes

16 files changed (+161 additions, -53 deletions)

View changed files

📝 app/build.gradle.kts (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt (+16 -8)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/SendManagerImpl.kt (+15 -8)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerTest.kt (+14 -13)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/SendManagerTest.kt (+15 -12)
➕ network/src/main/kotlin/com/bitwarden/network/model/GetCipherResponse.kt (+20 -0)
➕ network/src/main/kotlin/com/bitwarden/network/model/GetSendResponse.kt (+20 -0)
📝 network/src/main/kotlin/com/bitwarden/network/service/CiphersService.kt (+2 -1)
📝 network/src/main/kotlin/com/bitwarden/network/service/CiphersServiceImpl.kt (+12 -1)
📝 network/src/main/kotlin/com/bitwarden/network/service/IdentityServiceImpl.kt (+1 -0)
📝 network/src/main/kotlin/com/bitwarden/network/service/SendsService.kt (+4 -3)
📝 network/src/main/kotlin/com/bitwarden/network/service/SendsServiceImpl.kt (+12 -1)
📝 network/src/main/kotlin/com/bitwarden/network/util/ExceptionExtensions.kt (+7 -0)
📝 network/src/main/kotlin/com/bitwarden/network/util/NetworkErrorCode.kt (+1 -0)
📝 network/src/test/kotlin/com/bitwarden/network/service/CiphersServiceTest.kt (+11 -2)
📝 network/src/test/kotlin/com/bitwarden/network/service/SendsServiceTest.kt (+11 -2)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR updates the 2 spots in the app module that still reference the Retrofit library and allows us to remove that dependency from the app module completely.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6896 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 5/8/2026 **Status:** ✅ Merged **Merged:** 5/12/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `remove-retrofit-dependency` --- ### 📝 Commits (1) - [`9717423`](https://github.com/bitwarden/android/commit/97174239f9311c2c853fe67bb52c0def74297271) Remove Retrofit dependency from app module ### 📊 Changes **16 files changed** (+161 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt` (+16 -8) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/SendManagerImpl.kt` (+15 -8) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerTest.kt` (+14 -13) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/SendManagerTest.kt` (+15 -12) ➕ `network/src/main/kotlin/com/bitwarden/network/model/GetCipherResponse.kt` (+20 -0) ➕ `network/src/main/kotlin/com/bitwarden/network/model/GetSendResponse.kt` (+20 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/service/CiphersService.kt` (+2 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/service/CiphersServiceImpl.kt` (+12 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/service/IdentityServiceImpl.kt` (+1 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/service/SendsService.kt` (+4 -3) 📝 `network/src/main/kotlin/com/bitwarden/network/service/SendsServiceImpl.kt` (+12 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/util/ExceptionExtensions.kt` (+7 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/util/NetworkErrorCode.kt` (+1 -0) 📝 `network/src/test/kotlin/com/bitwarden/network/service/CiphersServiceTest.kt` (+11 -2) 📝 `network/src/test/kotlin/com/bitwarden/network/service/SendsServiceTest.kt` (+11 -2) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR updates the 2 spots in the `app` module that still reference the `Retrofit` library and allows us to remove that dependency from the `app` module completely. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 13:41:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#113995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?