github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-11-10 01:15:13 -06:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #5470] [MERGED] Clean up lint warnings #112834

New Issue
Closed
opened 2026-06-06 11:11:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 11:11:51 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5470
Author: @david-livefront
Created: 7/2/2025
Status: ✅ Merged
Merged: 7/3/2025
Merged by: @david-livefront

Base: main ← Head: clean-up-lint-warnings

📝 Commits (1)

📊 Changes

27 files changed (+60 additions, -90 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/FilledItemExtensions.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/model/MutualTlsCertificate.kt (+1 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensions.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/tiles/BitwardenGeneratorTileService.kt (+3 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/tiles/BitwardenVaultTileService.kt (+3 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialAuthenticationUserInterfaceImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialRegistrationUserInterfaceImpl.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+16 -19)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScope.kt (+1 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordField.kt (+4 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextField.kt (+4 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt (+2 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewModel.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModel.kt (+3 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/keychain/KeyChainManagerImpl.kt (+1 -1)

...and 7 more files

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR has no functional changes but addresses a lot of the lint warnings throughout the app. Mostly this fixes Shadowing, documentation linking, and unused classes.

These warnings were found with the Android Studio Inspect Code tool.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5470 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/2/2025 **Status:** ✅ Merged **Merged:** 7/3/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `clean-up-lint-warnings` --- ### 📝 Commits (1) - [`3fe9b16`](https://github.com/bitwarden/android/commit/3fe9b16a1280c5957e8f7488c1d35a61c8e2507d) Clean up lint warnings ### 📊 Changes **27 files changed** (+60 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/FilledItemExtensions.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/model/MutualTlsCertificate.kt` (+1 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/util/StateFlowExtensions.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/tiles/BitwardenGeneratorTileService.kt` (+3 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/tiles/BitwardenVaultTileService.kt` (+3 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialAuthenticationUserInterfaceImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialRegistrationUserInterfaceImpl.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+16 -19) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/coachmark/CoachMarkScope.kt` (+1 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/field/BitwardenPasswordField.kt` (+4 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextField.kt` (+4 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt` (+2 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewModel.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModel.kt` (+3 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/keychain/KeyChainManagerImpl.kt` (+1 -1) _...and 7 more files_ </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR has no functional changes but addresses a lot of the lint warnings throughout the app. Mostly this fixes Shadowing, documentation linking, and unused classes. These warnings were found with the Android Studio `Inspect Code` tool. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 11:11:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#112834