github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4032] [MERGED] Add logic for parting a TOTP code from a Uri or Intent #111666

New Issue
Closed
opened 2026-06-06 08:39:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 08:39:31 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4032
Author: @david-livefront
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/4/2024
Merged by: @david-livefront

Base: main ← Head: totp-parsing-logic

📝 Commits (1)

  • 99023d6 Add logic for parting a TOTP code from a Uri or Intent

📊 Changes

5 files changed (+276 additions, -0 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/ui/vault/model/TotpData.kt (+55 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/vault/util/TotpIntentUtils.kt (+10 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/vault/util/TotpUriUtils.kt (+48 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/vault/util/TotpIntentUtilsTest.kt (+62 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/vault/util/TotpUriUtilsTest.kt (+101 -0)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR adds logic for parsing a TOTP uri. This logic is not used yet but will be in a forthcoming PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4032 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/4/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `totp-parsing-logic` --- ### 📝 Commits (1) - [`99023d6`](https://github.com/bitwarden/android/commit/99023d63488a93c0b9a9cafa9e2c254d1c3f9a27) Add logic for parting a TOTP code from a Uri or Intent ### 📊 Changes **5 files changed** (+276 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/ui/vault/model/TotpData.kt` (+55 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/vault/util/TotpIntentUtils.kt` (+10 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/vault/util/TotpUriUtils.kt` (+48 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/vault/util/TotpIntentUtilsTest.kt` (+62 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/vault/util/TotpUriUtilsTest.kt` (+101 -0) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR adds logic for parsing a TOTP uri. This logic is not used yet but will be in a forthcoming PR. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 08:39:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#111666