github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-17 22:12:12 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3601] [MERGED] [PM-10024] Force focus on Master Password or Pin input field #111317

New Issue
Closed
opened 2026-06-06 07:56:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 07:56:39 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3601
Author: @qwexter
Created: 7/22/2024
Status: ✅ Merged
Merged: 8/7/2024
Merged by: @SaintPatrck

Base: main ← Head: autofocous_mainpassword

📝 Commits (1)

  • 321d015 Force focus on Master Password or Pin input field.

📊 Changes

3 files changed (+16 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt (+5 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt (+10 -0)

📄 Description

🎟️ Tracking

issues/3383

📔 Objective

Request autofocus on input field to show keyboard on Unlock Vault screen if biometric unlock is disabled or unavailable.
Also extent input field to support keyboard actions and and bind Unlick action to keyboard Done event too.
Add tests to cover cases with empty PIN\Password and ingnore Unlock action and focus related tests too.

Screenshots \ Video

demo_password

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3601 **Author:** [@qwexter](https://github.com/qwexter) **Created:** 7/22/2024 **Status:** ✅ Merged **Merged:** 8/7/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `autofocous_mainpassword` --- ### 📝 Commits (1) - [`321d015`](https://github.com/bitwarden/android/commit/321d0151d9599e8ff9db21ebf4cf313695811e94) Force focus on Master Password or Pin input field. ### 📊 Changes **3 files changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt` (+5 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt` (+10 -0) </details> ### 📄 Description ## 🎟️ Tracking [issues/3383](https://github.com/bitwarden/android/issues/3383) ## 📔 Objective Request autofocus on input field to show keyboard on Unlock Vault screen if biometric unlock is disabled or unavailable. Also extent input field to support keyboard actions and and bind Unlick action to keyboard Done event too. Add tests to cover cases with empty PIN\Password and ingnore Unlock action and focus related tests too. ## Screenshots \ Video ![demo_password](https://github.com/user-attachments/assets/7d1b7a1a-263e-4915-82fe-87f615a35d60) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 07:56:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#111317