github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-17 03:59:18 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4156] BITAU-182 BITAU-107 Don't show authetnicator sync toggle below API 31 #10875

New Issue
Closed
opened 2026-04-11 02:53:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:53:10 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/bitwarden/android/pull/4156

State: closed
Merged: Yes

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-182
https://livefront.atlassian.net/browse/BITAU-107

📔 Objective

The goal of this PR is to not show authenticator sync UI when API level is below 31. Also, I made a small copy update that Lukus found while I was in there.

📸 Screenshots

Note: the design file is still using v2 design, so we can ignore that difference.

Design Implementation

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/4156 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-182 https://livefront.atlassian.net/browse/BITAU-107 ## 📔 Objective The goal of this PR is to not show authenticator sync UI when API level is below 31. Also, I made a small copy update that Lukus found while I was in there. ## 📸 Screenshots Note: the design file is still using v2 design, so we can ignore that difference. | Design | Implementation | | --- | --- | | <img src="https://github.com/user-attachments/assets/5ae01fe0-7abc-4cf0-a3c8-6c22359394e5" width="300" /> | <img src="https://github.com/user-attachments/assets/b4f0e5a3-8706-46a7-a6a4-0da0d6ad2ccb" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2026-04-11 02:53:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#10875