github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4110] [PM-13789] add credential manager provider for passwords #10835

New Issue
Closed
opened 2026-04-11 02:52:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:52:26 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/4110

State: closed
Merged: Yes

🎟️ Tracking

https://github.com/bitwarden/android/issues/4100

📔 Objective

Currently there is only an implementation to provide or save Fido2 credentials via the CredentialManager.
The objective is to add the possibility to save and create Passwords.

Credential Manager usage: https://developer.android.com/identity/sign-in/credential-manager
Credential Provider to provide Credential Manager: https://developer.android.com/identity/sign-in/credential-provider
Example Project: https://github.com/android/identity-samples/tree/main/CredentialManager

Status

  • new BitwardenCredentialProviderService to handle incoming credential requests
  • new CredentialCompletionManager (from Fido2CompletionManager) to handle both passkeys and passwords
  • Overwrite Password/Username combination confirmation dialogs.

Working on:

  • Cleanup (formatting, comments etc)
  • fixing tests / adding tests

Found issues:

  • showFido2ErrorDialog doesn't always show the correct reason, however to stay consistent the showPaswordErrorDialog also shows always the same issue

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/4110 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking https://github.com/bitwarden/android/issues/4100 ## 📔 Objective Currently there is only an implementation to provide or save Fido2 credentials via the CredentialManager. The objective is to add the possibility to save and create Passwords. Credential Manager usage: https://developer.android.com/identity/sign-in/credential-manager Credential Provider to provide Credential Manager: https://developer.android.com/identity/sign-in/credential-provider Example Project: https://github.com/android/identity-samples/tree/main/CredentialManager ### Status - new BitwardenCredentialProviderService to handle incoming credential requests - new CredentialCompletionManager (from Fido2CompletionManager) to handle both passkeys and passwords - Overwrite Password/Username combination confirmation dialogs. Working on: - Cleanup (formatting, comments etc) - fixing tests / adding tests Found issues: - `showFido2ErrorDialog` doesn't always show the correct reason, however to stay consistent the `showPaswordErrorDialog` also shows always the same issue ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2026-04-11 02:52:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#10835
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?