github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 19:04:56 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6995] [MERGED] Chore: Move dispatcher for sdk functions into SDK sources #107248

New Issue
Closed
opened 2026-06-03 13:47:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 13:47:21 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6995
Author: @david-livefront
Created: 5/29/2026
Status: ✅ Merged
Merged: 5/29/2026
Merged by: @david-livefront

Base: main ← Head: update-sdk-dispatchers

📝 Commits (1)

  • 47e612f Move dispatcher for sdk functions into SDK sources

📊 Changes

11 files changed (+93 additions, -84 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt (+35 -30)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/di/AuthSdkModule.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerImpl.kt (+17 -22)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/di/AuthManagerModule.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+15 -20)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceImpl.kt (+6 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/di/GeneratorSdkModule.kt (+6 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt (+4 -5)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt (+2 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerTest.kt (+0 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceTest.kt (+5 -1)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR moves the usages of the io dispatcher for SDK operations in the the AuthSdkSource and the GeneratorSdkSource. This ensures that it will always be applied appropriately no matter where it is called from and simplifies the higher level classes that are currently do this manually.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6995 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 5/29/2026 **Status:** ✅ Merged **Merged:** 5/29/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `update-sdk-dispatchers` --- ### 📝 Commits (1) - [`47e612f`](https://github.com/bitwarden/android/commit/47e612f96a19392f7c2f9acef400c99371b2c0a4) Move dispatcher for sdk functions into SDK sources ### 📊 Changes **11 files changed** (+93 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt` (+35 -30) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/di/AuthSdkModule.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerImpl.kt` (+17 -22) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/di/AuthManagerModule.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+15 -20) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceImpl.kt` (+6 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/di/GeneratorSdkModule.kt` (+6 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt` (+4 -5) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt` (+2 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerTest.kt` (+0 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceTest.kt` (+5 -1) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR moves the usages of the io dispatcher for SDK operations in the the `AuthSdkSource` and the `GeneratorSdkSource`. This ensures that it will always be applied appropriately no matter where it is called from and simplifies the higher level classes that are currently do this manually. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 13:47:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#107248