github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-11-10 01:15:13 -06:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6897] [MERGED] Use string resource for button label #107161

New Issue
Closed
opened 2026-06-03 13:34:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 13:34:30 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6897
Author: @gabrbrand
Created: 5/9/2026
Status: ✅ Merged
Merged: 5/11/2026
Merged by: @david-livefront

Base: main ← Head: untranslatable-strings-tutorial-screen-bwa

📝 Commits (2)

  • e057737 Use string resource for button label
  • 46d1a51 Use sentence case

📊 Changes

3 files changed (+9 additions, -5 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/tutorial/TutorialScreen.kt (+1 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/tutorial/TutorialViewModel.kt (+6 -2)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/tutorial/TutorialScreenTest.kt (+2 -2)

📄 Description

📔 Objective

Currently a hard coded string is used for the primary button label on tutorial screens in the authenticator app, which makes it impossible to translate. A string resource in now used.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6897 **Author:** [@gabrbrand](https://github.com/gabrbrand) **Created:** 5/9/2026 **Status:** ✅ Merged **Merged:** 5/11/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `untranslatable-strings-tutorial-screen-bwa` --- ### 📝 Commits (2) - [`e057737`](https://github.com/bitwarden/android/commit/e05773727f922551caaa58ef96234a63242ece9c) Use string resource for button label - [`46d1a51`](https://github.com/bitwarden/android/commit/46d1a51fe51f2987d6d7108dd255d2b8fdc73e93) Use sentence case ### 📊 Changes **3 files changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/tutorial/TutorialScreen.kt` (+1 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/tutorial/TutorialViewModel.kt` (+6 -2) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/tutorial/TutorialScreenTest.kt` (+2 -2) </details> ### 📄 Description ## 📔 Objective Currently a hard coded string is used for the primary button label on tutorial screens in the authenticator app, which makes it impossible to translate. A string resource in now used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 13:34:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#107161