github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-20 20:47:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6873] [MERGED] PM-36474: bug: Ensure shared totp labels do not parse secret #107143

New Issue
Closed
opened 2026-06-03 13:32:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 13:32:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6873
Author: @david-livefront
Created: 5/5/2026
Status: ✅ Merged
Merged: 5/5/2026
Merged by: @david-livefront

Base: main ← Head: PM-36474-totp-labels

📝 Commits (1)

  • 828dfd2 PM-36474: Ensure shared totp labels do not parse secret

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/repository/util/SharedAccountDataExtensions.kt (+2 -1)

📄 Description

🎟️ Tracking

PM-36474

📔 Objective

This PR ensures that we do not parse the totp label as the secret for manually entered codes.

📸 Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6873 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 5/5/2026 **Status:** ✅ Merged **Merged:** 5/5/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-36474-totp-labels` --- ### 📝 Commits (1) - [`828dfd2`](https://github.com/bitwarden/android/commit/828dfd2a5d100702dec166b0b6ea5a83daab5862) PM-36474: Ensure shared totp labels do not parse secret ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/repository/util/SharedAccountDataExtensions.kt` (+2 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-36474](https://bitwarden.atlassian.net/browse/PM-36474) ## 📔 Objective This PR ensures that we do not parse the totp label as the secret for manually entered codes. ## 📸 Screenshots | Before | After | | --- | --- | | <img width="350" src="https://github.com/user-attachments/assets/68138a5f-0fc0-413e-92f0-e00db1e78621" /> | <img width="350" src="https://github.com/user-attachments/assets/f64ef493-e9aa-406e-81f3-94a643899a8f" /> | [PM-36474]: https://bitwarden.atlassian.net/browse/PM-36474?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 13:32:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#107143
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?