github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-25 07:41:55 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

http URL was saved when adding a new login #1068

New Issue
Closed
opened 2025-11-26 22:38:21 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-26 22:38:21 -06:00
Owner
Copy Link

Originally created by @yegle on GitHub (Jul 25, 2020).

Describe the Bug

When adding a new login from Android Chrome, a http:// URL was saved instead of https:// URL.

Steps To Reproduce

  1. In Chrome Android incognito tab, open a login form (e.g. https://github.com/login), confirm you are accessing using HTTPS.
  2. When prompt "Autofill with Bitwarden", go to my vault.
  3. Add a new login.

Expected Result

The url https://github.com/login should be in the URL field.

Actual Result

The url http://github.com/login is used in the URL field.

Screenshots or Videos

Environment

  • Device: Google Pixel 4 XL
  • Operating system: Android 11 Beta 2
  • Build Version (go to "Settings" → "About" in the app): 2.5.0 (3093)
  • Is this a Beta release? N

Additional Context

Originally created by @yegle on GitHub (Jul 25, 2020). <!-- Comment: Please do not submit feature requests. The [Community Forums][1] has a section for submitting, voting for, and discussing product feature requests. [1]: https://community.bitwarden.com --> ## Describe the Bug <!-- Comment: A clear and concise description of what the bug is. --> When adding a new login from Android Chrome, a http:// URL was saved instead of https:// URL. ## Steps To Reproduce <!-- Comment: How can we reproduce the behavior: --> 1. In Chrome Android incognito tab, open a login form (e.g. https://github.com/login), confirm you are accessing using HTTPS. 2. When prompt "Autofill with Bitwarden", go to my vault. 3. Add a new login. ## Expected Result <!-- Comment: A clear and concise description of what you expected to happen. --> The url `https://github.com/login` should be in the URL field. ## Actual Result <!-- Comment: A clear and concise description of what is happening. --> The url `http://github.com/login` is used in the URL field. ## Screenshots or Videos <!-- Comment: If applicable, add screenshots and/or a short video to help explain your problem. --> ## Environment - Device: Google Pixel 4 XL - Operating system: Android 11 Beta 2 - Build Version (go to "Settings" → "About" in the app): 2.5.0 (3093) - Is this a Beta release? N ## Additional Context <!-- Comment: Add any other context about the problem here. -->
GiteaMirror commented 2025-11-26 22:38:21 -06:00
Author
Owner
Copy Link

@RePacked commented on GitHub (Aug 4, 2020):

I can't reproduce this. Shows correct URI for me.

Device: OnePlus 8
Operating system: Android 10 (OxygenOS 10.5.9.IN21BA)
Build Version: 2.5.0 (3093)
Is this a Beta release? No

@RePacked commented on GitHub (Aug 4, 2020): I can't reproduce this. Shows correct URI for me. Device: OnePlus 8 Operating system: Android 10 (OxygenOS 10.5.9.IN21BA) Build Version: 2.5.0 (3093) Is this a Beta release? No
GiteaMirror commented 2025-11-26 22:38:22 -06:00
Author
Owner
Copy Link

@yegle commented on GitHub (Aug 7, 2020):

I can also reproduce it on an Android 10 Pixel 3A phone (QQ3A.200805.001).

@yegle commented on GitHub (Aug 7, 2020): I can also reproduce it on an Android 10 Pixel 3A phone (QQ3A.200805.001).
GiteaMirror commented 2025-11-26 22:38:22 -06:00
Author
Owner
Copy Link

@MGibson1 commented on GitHub (Dec 18, 2020):

@yegle, What is the Autofill framework you have enabled? From your issue and description I think you're using Accessibility with Draw-Over enabled. Is this correct?

If so, this is kind of an upstream issue with Chrome. The way accessibility grabs the URI is through the address bar in Chrome. Chrome has made the choice to remove the URI scheme from that bar, and so our accessibility code can't get it. We are currently attempting to prepend http:// and see if that's a valid URI. If it is, we use that. That's why you get http://github.com/login instead of https://.... The reason for that choice is it's more likely to work. However, these days we really should assume https:// first.

I'm submitting a PR to update this fallback case when we find no scheme to first attempt to prepend https://, then http://.

Again, the above assumes you're using Accessibility for your Autofill needs.

@MGibson1 commented on GitHub (Dec 18, 2020): @yegle, What is the Autofill framework you have enabled? From your issue and description I think you're using Accessibility with Draw-Over enabled. Is this correct? If so, this is _kind of_ an upstream issue with Chrome. The way accessibility grabs the URI is through the address bar in Chrome. Chrome has made the choice to remove the URI scheme from that bar, and so our accessibility code can't get it. We are currently attempting to prepend `http://` and see if that's a valid URI. If it is, we use that. That's why you get `http://github.com/login` instead of `https://...`. The reason for that choice is it's more likely to work. However, these days we really should assume `https://` first. I'm submitting a PR to update this fallback case when we find no scheme to first attempt to prepend `https://`, then `http://`. Again, the above assumes you're using Accessibility for your Autofill needs.
GiteaMirror commented 2025-11-26 22:38:22 -06:00
Author
Owner
Copy Link

@yegle commented on GitHub (Dec 19, 2020):

Ah yes I use accessibility instead of the Autofill API.

Thanks for the fix! I agree the default should be https:// nowadays.

@yegle commented on GitHub (Dec 19, 2020): Ah yes I use accessibility instead of the Autofill API. Thanks for the fix! I agree the default should be https:// nowadays.
GiteaMirror commented 2025-11-26 22:38:22 -06:00
Author
Owner
Copy Link

@MGibson1 commented on GitHub (Dec 21, 2020):

I'm going to mark this closed since #1186 should have fixed this specific issue. We'll continue to have these problems with accessibility-based autofill, but hopefully the autofill framework fro android shores up in the future and it won't be a problem.

@MGibson1 commented on GitHub (Dec 21, 2020): I'm going to mark this closed since #1186 should have fixed this specific issue. We'll continue to have these problems with accessibility-based autofill, but hopefully the autofill framework fro android shores up in the future and it won't be a problem.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#1068
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?