github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-08 10:15:11 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6151] [MERGED] [PM-28029] Address Sonar Cloud and Linter errors #106566

New Issue
Closed
opened 2026-06-03 12:14:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 12:14:21 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6151
Author: @vvolkgang
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/11/2025
Merged by: @vvolkgang

Base: main ← Head: vvolkgang/sonar-cloud-hotspots

📝 Commits (7)

  • 5f695c8 refactor log-inputs
  • fcb66d5 _version.yml - apply zizmor suggestions
  • e4c13ab Moved id-token permission to job that needs it
  • 95dc64e Re-using log-inputs action
  • 5ebd7a7 Set default value for _PATCH_VERSION when repo doesn't have tags.
  • a7a147d zizmor - Remove secrets: inherit from version workflow
  • a78d787 Merge branch 'main' into vvolkgang/sonar-cloud-hotspots

📊 Changes

5 files changed (+60 additions, -66 deletions)

View changed files

📝 .github/actions/log-inputs/action.yml (+10 -6)
📝 .github/workflows/_version.yml (+37 -23)
📝 .github/workflows/build-authenticator.yml (+5 -13)
📝 .github/workflows/build.yml (+5 -13)
📝 .github/workflows/publish-store.yml (+3 -11)

📄 Description

🎟️ Tracking

PM-28029

📔 Objective

Address warnings and errors raised by Sonar Cloud and our Linter.

  • _version.yml and log-input action copied from bitwarden/ios where these had been addressed recently.
  • Moved id-token permission to the jobs using it.
  • Replaced existing steps with the log-input action.
  • zizmor - Removed secrets: inherit from _version.yml jobs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6151 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/11/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `vvolkgang/sonar-cloud-hotspots` --- ### 📝 Commits (7) - [`5f695c8`](https://github.com/bitwarden/android/commit/5f695c8a1dc4b7afe519a3748bb9c3f29a77946e) refactor log-inputs - [`fcb66d5`](https://github.com/bitwarden/android/commit/fcb66d5498c9a9b9ba3599e5e979c9a305167827) _version.yml - apply zizmor suggestions - [`e4c13ab`](https://github.com/bitwarden/android/commit/e4c13ab3e215bc685225064883e7fdaf36eac5d2) Moved id-token permission to job that needs it - [`95dc64e`](https://github.com/bitwarden/android/commit/95dc64ee0f2f9928b9dda2bb5ff8c345bf390ff6) Re-using log-inputs action - [`5ebd7a7`](https://github.com/bitwarden/android/commit/5ebd7a7fa94586c40f382d9da873e4e0448fcef4) Set default value for _PATCH_VERSION when repo doesn't have tags. - [`a7a147d`](https://github.com/bitwarden/android/commit/a7a147dd37fad54305c15835102524e070b23263) zizmor - Remove secrets: inherit from version workflow - [`a78d787`](https://github.com/bitwarden/android/commit/a78d787c9d2d92f5af9901acb6c3298840015258) Merge branch 'main' into vvolkgang/sonar-cloud-hotspots ### 📊 Changes **5 files changed** (+60 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/log-inputs/action.yml` (+10 -6) 📝 `.github/workflows/_version.yml` (+37 -23) 📝 `.github/workflows/build-authenticator.yml` (+5 -13) 📝 `.github/workflows/build.yml` (+5 -13) 📝 `.github/workflows/publish-store.yml` (+3 -11) </details> ### 📄 Description ## 🎟️ Tracking PM-28029 ## 📔 Objective Address warnings and errors raised by Sonar Cloud and our Linter. * `_version.yml` and `log-input` action copied from bitwarden/ios where these had been addressed recently. * Moved `id-token` permission to the jobs using it. * Replaced existing steps with the `log-input` action. * zizmor - Removed `secrets: inherit` from `_version.yml` jobs. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 12:14:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#106566