github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-15 08:34:16 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4101] [MERGED] PM-13627 show action card on vault settings if applicable #104889

New Issue
Closed
opened 2026-06-03 08:09:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 08:09:17 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4101
Author: @dseverns-livefront
Created: 10/16/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-13627-import-logins-card-settings

📝 Commits (6)

📊 Changes

4 files changed (+240 additions, -4 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/vault/VaultSettingsScreen.kt (+35 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/vault/VaultSettingsViewModel.kt (+79 -4)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/vault/VaultSettingsScreenTest.kt (+56 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/vault/VaultSettingsViewModelTest.kt (+70 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13627

📔 Objective

  • show the action card for the import logins on the VaultSettings screen as well, same logic applies to showing, feature flag must be enabled and vault must be empty.

📸 Screenshots

https://github.com/user-attachments/assets/6096d2b6-90a2-4440-8baf-86f0d10b224b

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4101 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/16/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-13627-import-logins-card-settings` --- ### 📝 Commits (6) - [`77ff11e`](https://github.com/bitwarden/android/commit/77ff11e567b4a2772b317937e95c8660121aaacf) PM-13627 show action card on vault settings if the showImportLogins first time state is true - [`0edce63`](https://github.com/bitwarden/android/commit/0edce63805205d46bbbd8338e59126ea3581f33d) fix test - [`225d44f`](https://github.com/bitwarden/android/commit/225d44f6c462426609187689aa72e9525dbf852a) update to use firsttimemanager - [`62daca7`](https://github.com/bitwarden/android/commit/62daca74418f2484c2203c66995af98e1f7192c2) remove log - [`ab3af60`](https://github.com/bitwarden/android/commit/ab3af6024f83d123e32293514d02c21e6399b08b) imports - [`f59a832`](https://github.com/bitwarden/android/commit/f59a8326fc629cb81b7c3e4ffd1f443cc8a15fc1) syntax ### 📊 Changes **4 files changed** (+240 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/vault/VaultSettingsScreen.kt` (+35 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/vault/VaultSettingsViewModel.kt` (+79 -4) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/vault/VaultSettingsScreenTest.kt` (+56 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/vault/VaultSettingsViewModelTest.kt` (+70 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13627 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - show the action card for the import logins on the VaultSettings screen as well, same logic applies to showing, feature flag must be enabled and vault must be empty. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/6096d2b6-90a2-4440-8baf-86f0d10b224b <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 08:09:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#104889