github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 09:06:13 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3398] [MERGED] BIT-2398 if the org associated with a cipher uses TOTP enable the aut… #104404

New Issue
Closed
opened 2026-06-03 06:54:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 06:54:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3398
Author: @dseverns-livefront
Created: 7/3/2024
Status: ✅ Merged
Merged: 7/5/2024
Merged by: @dseverns-livefront

Base: main ← Head: BIT-2398/check-for-org-totp

📝 Commits (4)

  • 303ce93 BIT-2398 if the org associated with a cipher uses TOTP enable the autofill where it would otherwise be limited to premium user
  • f661a04 PR feedback updating test
  • 4608ec3 Update TOTP item count on vault screen to show if any org related TOTP codes, added filtering to TOTP code lists
  • 5afbe3c line length

📊 Changes

16 files changed (+314 additions, -11 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillCompletionManagerImpl.kt (+2 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/TotpCodeManagerImpl.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/model/VerificationCodeItem.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+9 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt (+3 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeViewModel.kt (+28 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/manager/AutofillCompletionManagerTest.kt (+90 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+4 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensionsTest.kt (+37 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt (+73 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeViewModelTest.kt (+58 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/util/VerificationCodeDataUtil.kt (+1 -0)

📄 Description

🎟️ Tracking

BIT-2398

📔 Objective

When there are features around TOTP, in addition to having premium, accounts which have a cipher which had TOTP enabled by an Org. should also be considered

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3398 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 7/5/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `BIT-2398/check-for-org-totp` --- ### 📝 Commits (4) - [`303ce93`](https://github.com/bitwarden/android/commit/303ce9357db72f47e6abecc40540bcb00cd1a6cd) BIT-2398 if the org associated with a cipher uses TOTP enable the autofill where it would otherwise be limited to premium user - [`f661a04`](https://github.com/bitwarden/android/commit/f661a04f83d7b2bd3fcec9fa114f501f5530be02) PR feedback updating test - [`4608ec3`](https://github.com/bitwarden/android/commit/4608ec38e39771c646dc95c5a8ca3420376c35c9) Update TOTP item count on vault screen to show if any org related TOTP codes, added filtering to TOTP code lists - [`5afbe3c`](https://github.com/bitwarden/android/commit/5afbe3c43bc38d4258f27f929c0d827a416c9675) line length ### 📊 Changes **16 files changed** (+314 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillCompletionManagerImpl.kt` (+2 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/TotpCodeManagerImpl.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/model/VerificationCodeItem.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+9 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt` (+3 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeViewModel.kt` (+28 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/manager/AutofillCompletionManagerTest.kt` (+90 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+4 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensionsTest.kt` (+37 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt` (+73 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeViewModelTest.kt` (+58 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/util/VerificationCodeDataUtil.kt` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking [BIT-2398](https://livefront.atlassian.net/jira/software/c/projects/BIT/boards/91?assignee=712020%3A179d6d43-0428-44b1-82e0-e454ccab0c92&selectedIssue=BIT-2398) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective When there are features around TOTP, in addition to having premium, accounts which have a cipher which had TOTP enabled by an Org. should also be considered <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 06:54:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#104404
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?