github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-25 07:41:55 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

View and Copy Password not visible in "locked" upgrade path #1040

New Issue
Closed
opened 2025-11-26 22:37:25 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-26 22:37:25 -06:00
Owner
Copy Link

Originally created by @cscharf on GitHub (Jun 11, 2020).

Originally assigned to: @cscharf on GitHub.

Describe the Bug

When upgrading Bitwarden from the prior version and your vault is only locked (not logged out), ciphers are not re-pulled from the API/servers and therefore changes from recent hidden password functionally which set the default of View = true are not set, leaving the value false and therefore hides all passwords/disabled copy.

Steps To Reproduce

Tested on iOS v2.4.4 (175) via Test Flight (beta) from latest build; test from https://github.com/bitwarden/mobile/pull/920.

  1. Open Bitwarden app and log in
  2. Upgrade to latest version of application
  3. View any password cipher
  4. Note view or copy options are not present until you log out and back in

Expected Result

Cipher class should handle a scenario where "not set" plays into a default of "true" rather than purely relying on the server fetch operation wholly in this scenario (a common upgrade path scenario).

When I open my vault without any preference set, after upgrading to this version, I should have view and copy password options available.

Actual Result

When I open my vault without any preference set, after upgrading to this version, I do not have view and copy password options available.

Environment

  • Device: iPhone Xs
  • Operating system: iOS 13.4.1
  • BW Version: iOS v2.4.4 (175)
  • Is this a Beta release? Y (Test Flight)

Additional Context

see: https://github.com/bitwarden/mobile/pull/920...

Could this also affect other clients in a similar scenario (desktop, browser and web)?

CC: @Hinton

Originally created by @cscharf on GitHub (Jun 11, 2020). Originally assigned to: @cscharf on GitHub. ## Describe the Bug When upgrading Bitwarden from the prior version and your vault is only locked (not logged out), ciphers are not re-pulled from the API/servers and therefore changes from recent hidden password functionally which set the default of `View = true` are not set, leaving the value `false` and therefore hides all passwords/disabled copy. ## Steps To Reproduce Tested on iOS v2.4.4 (175) via Test Flight (beta) from latest build; test from https://github.com/bitwarden/mobile/pull/920. 1. Open Bitwarden app and log in 2. Upgrade to latest version of application 3. View any password cipher 4. Note view or copy options are not present until you log out and back in ## Expected Result `Cipher` class should handle a scenario where "not set" plays into a default of "true" rather than purely relying on the server fetch operation wholly in this scenario (a common upgrade path scenario). When I open my vault without any preference set, after upgrading to this version, I should have view and copy password options available. ## Actual Result When I open my vault without any preference set, after upgrading to this version, I do not have view and copy password options available. ## Environment - Device: iPhone Xs - Operating system: iOS 13.4.1 - BW Version: iOS v2.4.4 (175) - Is this a Beta release? Y (Test Flight) ## Additional Context see: https://github.com/bitwarden/mobile/pull/920... **Could this also affect other clients in a similar scenario (desktop, browser and web)?** CC: @Hinton
GiteaMirror commented 2025-11-26 22:37:26 -06:00
Author
Owner
Copy Link

@Hinton commented on GitHub (Jun 12, 2020):

Hmm, nice find.

Re-checking the PR, my current theory is that we only set the CipherResponse to contain the default value. So in the event of a user not receiving new data the CipherData would default to false.

I'll see if I can replicate the issue and get a PR open to resolve it. And verify if it exists on other clients.

@Hinton commented on GitHub (Jun 12, 2020): Hmm, nice find. Re-checking the PR, my current theory is that we only set the `CipherResponse` to contain the default value. So in the event of a user not receiving new data the `CipherData` would default to false. I'll see if I can replicate the issue and get a PR open to resolve it. And verify if it exists on other clients.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#1040
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?