github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-22 15:21:28 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2339] [MERGED] [PS-2413] set all kdf params on account profile #103716

New Issue
Closed
opened 2026-06-03 05:14:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 05:14:27 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2339
Author: @kspearrin
Created: 2/2/2023
Status: ✅ Merged
Merged: 2/2/2023
Merged by: @kspearrin

Base: master ← Head: kdfaccntfix

📝 Commits (1)

  • ba957ab set all kdf params on account profile

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/Core/Services/AuthService.cs (+2 -0)

📄 Description

ref: https://bitwarden.atlassian.net/browse/PS-2413

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With the introduction of Argon2, KdfMemory and KdfParallelism need to be set to the account profile in state service. This spot was missed in the original work, resulting in null values for these fields.

Code changes

  • AuthService.cs: Add KdfMemory and KdfParallelism to the AccountProfile object saved after login.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2339 **Author:** [@kspearrin](https://github.com/kspearrin) **Created:** 2/2/2023 **Status:** ✅ Merged **Merged:** 2/2/2023 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `kdfaccntfix` --- ### 📝 Commits (1) - [`ba957ab`](https://github.com/bitwarden/android/commit/ba957abd657529d9836b3a086cb0db2430146085) set all kdf params on account profile ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/AuthService.cs` (+2 -0) </details> ### 📄 Description ref: https://bitwarden.atlassian.net/browse/PS-2413 ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective With the introduction of Argon2, KdfMemory and KdfParallelism need to be set to the account profile in state service. This spot was missed in the original work, resulting in null values for these fields. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AuthService.cs:** Add KdfMemory and KdfParallelism to the `AccountProfile` object saved after login. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 05:14:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#103716