github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1756] [MERGED] Account Switching fix avatar blinking #103305

New Issue
Closed
opened 2026-06-03 04:31:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 04:31:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1756
Author: @fedemkr
Created: 2/8/2022
Status: ✅ Merged
Merged: 2/8/2022
Merged by: @fedemkr

Base: accountswitching ← Head: accountswitching-fix-avatar-blinking

📝 Commits (2)

  • 7045bf9 Overriden Equals on AvatarImageSource so it doesn't get set multiple times when it's the same image thus producing blinking on tab chaged
  • 05c50ef Merge branch 'accountswitching' into accountswitching-fix-avatar-blinking

📊 Changes

1 file changed (+17 additions, -0 deletions)

View changed files

📝 src/App/Controls/AvatarImageSource.cs (+17 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix Avatar blinking when changing tabs and going back to Groupings tab.

Code changes

  • AvatarImageSource: Overriden Equals and GetHashCode so the instance is properly compared based on the _data thus disallowing to set an instance with the same _data multiple times when using SetProperty(...) on the ViewModels.

Testing requirements

The Avatar shouldn't blink when changing tabs and returning to the first one (where the avatar is shown)

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1756 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/8/2022 **Status:** ✅ Merged **Merged:** 2/8/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `accountswitching` ← **Head:** `accountswitching-fix-avatar-blinking` --- ### 📝 Commits (2) - [`7045bf9`](https://github.com/bitwarden/android/commit/7045bf9d062ee400a7e03ede161a7aa54ad620cf) Overriden Equals on AvatarImageSource so it doesn't get set multiple times when it's the same image thus producing blinking on tab chaged - [`05c50ef`](https://github.com/bitwarden/android/commit/05c50efff139f81509983896d189bbe6b0ff5a73) Merge branch 'accountswitching' into accountswitching-fix-avatar-blinking ### 📊 Changes **1 file changed** (+17 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/AvatarImageSource.cs` (+17 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix Avatar blinking when changing tabs and going back to Groupings tab. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AvatarImageSource:** Overriden Equals and GetHashCode so the instance is properly compared based on the `_data` thus disallowing to set an instance with the same `_data` multiple times when using `SetProperty(...)` on the ViewModels. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> The Avatar shouldn't blink when changing tabs and returning to the first one (where the avatar is shown) ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 04:31:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#103305
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?