github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 03:59:18 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3153] [MERGED] [PM-7365] Fix User Verification to be done correctly on passkey creation on Never timeout vault #10198

New Issue
Closed
opened 2026-04-11 02:38:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:38:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3153
Author: @fedemkr
Created: 4/12/2024
Status: ✅ Merged
Merged: 4/15/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: mobiletf/pm-7365/fix-uv-not-triggered-passkey-creation-android

📝 Commits (1)

  • 1a0f629 PM-7365 Fix setting HasUnlockedInThisTransaction on passkey creation on android

📊 Changes

4 files changed (+20 additions, -5 deletions)

View changed files

📝 src/App/Platforms/Android/Autofill/Fido2MakeCredentialUserInterface.cs (+11 -5)
📝 src/Core/Abstractions/IFido2MakeCredentialConfirmationUserInterface.cs (+2 -0)
📝 src/Core/Utilities/AccountManagement/AccountsManager.cs (+4 -0)
📝 src/Core/Utilities/AppHelpers.cs (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix updating flag of having unlocked in the current transaction on passkey creation in order for the User Verification to perform correctly on unlocked vaults.

Code changes

  • Fido2MakeCredentialUserInterface: Added function setter that gets the current state of if the vault has been unlocked in the current transaction and used that inside the flow.
  • AppHelpers: Set the aforementioned function with the AppOptions property.
  • AccountsManager: Clear has been unlocked in the current transaction flag when switching accounts.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3153 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/12/2024 **Status:** ✅ Merged **Merged:** 4/15/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `mobiletf/pm-7365/fix-uv-not-triggered-passkey-creation-android` --- ### 📝 Commits (1) - [`1a0f629`](https://github.com/bitwarden/android/commit/1a0f629c4377e0cbfd54c5e5a9a36dc797cd1c90) PM-7365 Fix setting HasUnlockedInThisTransaction on passkey creation on android ### 📊 Changes **4 files changed** (+20 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Autofill/Fido2MakeCredentialUserInterface.cs` (+11 -5) 📝 `src/Core/Abstractions/IFido2MakeCredentialConfirmationUserInterface.cs` (+2 -0) 📝 `src/Core/Utilities/AccountManagement/AccountsManager.cs` (+4 -0) 📝 `src/Core/Utilities/AppHelpers.cs` (+3 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix updating flag of having unlocked in the current transaction on passkey creation in order for the User Verification to perform correctly on unlocked vaults. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Fido2MakeCredentialUserInterface:** Added function setter that gets the current state of if the vault has been unlocked in the current transaction and used that inside the flow. * **AppHelpers:** Set the aforementioned function with the `AppOptions` property. * **AccountsManager:** Clear has been unlocked in the current transaction flag when switching accounts. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:38:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#10198
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?