github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #6999] PM-37887: Feat: Update the Key Connector vault unlock to use the SDK #100428

New Issue
Open
opened 2026-05-31 05:18:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-31 05:18:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6999
Author: @david-livefront
Created: 5/29/2026
Status: 🔄 Open

Base: main ← Head: PM-37887-sdk-key-connector-unlock

📝 Commits (1)

  • 8ae12b4 PM-37887: Update the Key Connector vault unlock to use the SDK

📊 Changes

11 files changed (+65 additions, -191 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManager.kt (+0 -9)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerImpl.kt (+0 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+18 -30)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+3 -3)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerTest.kt (+0 -31)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+44 -48)
📝 network/src/main/kotlin/com/bitwarden/network/api/UnauthenticatedKeyConnectorApi.kt (+0 -8)
➖ network/src/main/kotlin/com/bitwarden/network/model/KeyConnectorMasterKeyResponseJson.kt (+0 -12)
📝 network/src/main/kotlin/com/bitwarden/network/service/AccountsService.kt (+0 -12)
📝 network/src/main/kotlin/com/bitwarden/network/service/AccountsServiceImpl.kt (+0 -12)
📝 network/src/test/kotlin/com/bitwarden/network/service/AccountsServiceTest.kt (+0 -16)

📄 Description

🎟️ Tracking

PM-37887

📔 Objective

This PR migrates the KeyConnector login process over to the SDK completely. Removing the need for us to call the getMasterKeyFromKeyConnector API ourselves.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6999 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 5/29/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `PM-37887-sdk-key-connector-unlock` --- ### 📝 Commits (1) - [`8ae12b4`](https://github.com/bitwarden/android/commit/8ae12b44fe428465f663a75b17d02be53f411a67) PM-37887: Update the Key Connector vault unlock to use the SDK ### 📊 Changes **11 files changed** (+65 additions, -191 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManager.kt` (+0 -9) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerImpl.kt` (+0 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+18 -30) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+3 -3) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/manager/KeyConnectorManagerTest.kt` (+0 -31) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+44 -48) 📝 `network/src/main/kotlin/com/bitwarden/network/api/UnauthenticatedKeyConnectorApi.kt` (+0 -8) ➖ `network/src/main/kotlin/com/bitwarden/network/model/KeyConnectorMasterKeyResponseJson.kt` (+0 -12) 📝 `network/src/main/kotlin/com/bitwarden/network/service/AccountsService.kt` (+0 -12) 📝 `network/src/main/kotlin/com/bitwarden/network/service/AccountsServiceImpl.kt` (+0 -12) 📝 `network/src/test/kotlin/com/bitwarden/network/service/AccountsServiceTest.kt` (+0 -16) </details> ### 📄 Description ## 🎟️ Tracking [PM-37887](https://bitwarden.atlassian.net/browse/PM-37887) ## 📔 Objective This PR migrates the KeyConnector login process over to the SDK completely. Removing the need for us to call the `getMasterKeyFromKeyConnector` API ourselves. [PM-37887]: https://bitwarden.atlassian.net/browse/PM-37887?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-31 05:18:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#100428
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?