github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-05 01:27:54 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6992] [PM-37255] feat: Wire fill-assist manager into vault sync and app startup #100421

New Issue
Open
opened 2026-05-31 05:17:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-31 05:17:30 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6992
Author: @aj-rosado
Created: 5/29/2026
Status: 🔄 Open

Base: PM-37255/fill-assist-data-layer ← Head: PM-37255/fill-assist-integration

📝 Commits (2)

  • 09692af wire fill-assist manager into vault sync and app startup
  • b718f56 Merge branch 'PM-37255/fill-assist-data-layer' into PM-37255/fill-assist-integration

📊 Changes

4 files changed (+16 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/BitwardenApplication.kt (+4 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultSyncManagerImpl.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt (+3 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultSyncManagerTest.kt (+6 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37255

📔 Objective

Connects the fill-assist manager to the rest of the app so rules are fetched and kept fresh automatically.

Changes:

  • VaultSyncManagerImpl — calls fillAssistManager.syncIfNecessary() after vault data is stored; fill-assist failures are silently dropped and never affect vault sync
  • VaultManagerModule — injects FillAssistManager into VaultSyncManager
  • BitwardenApplication — injects FillAssistManager to trigger eager initialization; the init {} block subscribes to serverConfigStateFlow for config-change-triggered syncs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6992 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 5/29/2026 **Status:** 🔄 Open **Base:** `PM-37255/fill-assist-data-layer` ← **Head:** `PM-37255/fill-assist-integration` --- ### 📝 Commits (2) - [`09692af`](https://github.com/bitwarden/android/commit/09692afff63b2a0bcda137cf926e3354e13bdb30) wire fill-assist manager into vault sync and app startup - [`b718f56`](https://github.com/bitwarden/android/commit/b718f56bed27d9fdc3d322fcc4d7beb2a6d9cc4b) Merge branch 'PM-37255/fill-assist-data-layer' into PM-37255/fill-assist-integration ### 📊 Changes **4 files changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/BitwardenApplication.kt` (+4 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultSyncManagerImpl.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt` (+3 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultSyncManagerTest.kt` (+6 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-37255 ## 📔 Objective Connects the fill-assist manager to the rest of the app so rules are fetched and kept fresh automatically. **Changes:** - `VaultSyncManagerImpl` — calls `fillAssistManager.syncIfNecessary()` after vault data is stored; fill-assist failures are silently dropped and never affect vault sync - `VaultManagerModule` — injects `FillAssistManager` into `VaultSyncManager` - `BitwardenApplication` — injects `FillAssistManager` to trigger eager initialization; the `init {}` block subscribes to `serverConfigStateFlow` for config-change-triggered syncs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-31 05:17:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#100421