github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-21 04:57:53 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6951] [MERGED] [PM-37294] fix: Announce external-link affordance on premium upgrade CTAs #100381

New Issue
Closed
opened 2026-05-31 05:12:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-31 05:12:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6951
Author: @SaintPatrck
Created: 5/20/2026
Status: ✅ Merged
Merged: 5/20/2026
Merged by: @SaintPatrck

Base: main ← Head: premium-upgrade/pm-37294-action-card-external-link-a11y

📝 Commits (2)

  • 5a1eaf9 [PM-37294] fix: Announce external-link affordance on premium upgrade CTAs
  • f143af6 Consolidate UpgradedToPremium card test in GeneratorScreenTest

📊 Changes

12 files changed (+91 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreen.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreen.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendContent.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreenTest.kt (+22 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreenTest.kt (+3 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt (+3 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreenTest.kt (+3 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+3 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/card/BitwardenActionCard.kt (+4 -0)
➕ ui/src/test/kotlin/com/bitwarden/ui/platform/components/card/BitwardenActionCardTest.kt (+47 -0)

📄 Description

🎟️ Tracking

📔 Objective

Screen readers announced only the visible label on the premium upgrade CTAs that leave the app for a web destination, so users hit a surprise context switch. Mark each as an external link so the affordance is appended to the announced label:

  • PM-37294 — "Learn more" on the Upgraded-to-Premium action card (Vault, Send, Settings, Generator)
  • PM-37717 — Manage plan on the Premium plan screen
  • PM-37718 — Cancel Premium on the Premium plan screen

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6951 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/20/2026 **Status:** ✅ Merged **Merged:** 5/20/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `premium-upgrade/pm-37294-action-card-external-link-a11y` --- ### 📝 Commits (2) - [`5a1eaf9`](https://github.com/bitwarden/android/commit/5a1eaf92decfbdc922fade6cf53d8f31c6e996ed) [PM-37294] fix: Announce external-link affordance on premium upgrade CTAs - [`f143af6`](https://github.com/bitwarden/android/commit/f143af67fa2f895af4721f91e0c5c18aadf86578) Consolidate UpgradedToPremium card test in GeneratorScreenTest ### 📊 Changes **12 files changed** (+91 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreen.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreen.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendContent.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreenTest.kt` (+22 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreenTest.kt` (+3 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt` (+3 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreenTest.kt` (+3 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+3 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/card/BitwardenActionCard.kt` (+4 -0) ➕ `ui/src/test/kotlin/com/bitwarden/ui/platform/components/card/BitwardenActionCardTest.kt` (+47 -0) </details> ### 📄 Description ## 🎟️ Tracking - https://bitwarden.atlassian.net/browse/PM-37294 - https://bitwarden.atlassian.net/browse/PM-37717 - https://bitwarden.atlassian.net/browse/PM-37718 ## 📔 Objective Screen readers announced only the visible label on the premium upgrade CTAs that leave the app for a web destination, so users hit a surprise context switch. Mark each as an external link so the affordance is appended to the announced label: - **PM-37294** — "Learn more" on the Upgraded-to-Premium action card (Vault, Send, Settings, Generator) - **PM-37717** — Manage plan on the Premium plan screen - **PM-37718** — Cancel Premium on the Premium plan screen --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-31 05:12:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#100381
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?