github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2905] [MERGED] Update version bump workflow #10022

New Issue
Closed
opened 2026-04-11 02:33:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:33:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2905
Author: @vgrassia
Created: 12/15/2023
Status: ✅ Merged
Merged: 12/15/2023
Merged by: @vgrassia

Base: main ← Head: update-version-bump-workflow

📝 Commits (2)

  • 24e017e Update version bump and add cut RC workflow
  • 3191ff8 Add input for cutting RC branch

📊 Changes

2 files changed (+42 additions, -8 deletions)

View changed files

➕ .github/workflows/_cut_rc.yml (+29 -0)
📝 .github/workflows/version-bump.yml (+13 -8)

📄 Description

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR updates how we bump version numbers and cut the rc branch. The new procedure is outlined below.

If you have more than one project to cut rc for:

  • Go to the DevOps repository and run the RC Branch Manager workflow with the following inputs.
    • cutmode.
    • Desired projects checked.
    • Version Number filled out.

You can also just run the Version Bump workflow in the repository by itself if you don't need to cut rc for multiple projects.

The following will take place:

  • The version number is verified.
  • The Version Bump workflow in the each repository is called via the GitHub CLI.
  • The version will be bumped, committed to a branch, PR created, PR approved, PR merged.
  • The Cut RC Branch workflow will run to create and push the rc branch.
  • A Slack message will be sent to notify of the PR.

Code changes

  • .github/workflows/_cut_rc.yml: Added to help cut the rc branch.
  • .github/workflows/version-bump.yml: Removed workflow_call trigger as it's no longer needed. Added input for cutting the rc branch.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2905 **Author:** [@vgrassia](https://github.com/vgrassia) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 12/15/2023 **Merged by:** [@vgrassia](https://github.com/vgrassia) **Base:** `main` ← **Head:** `update-version-bump-workflow` --- ### 📝 Commits (2) - [`24e017e`](https://github.com/bitwarden/android/commit/24e017eeb90ecea2b25f5eb5f1f03784cde387e7) Update version bump and add cut RC workflow - [`3191ff8`](https://github.com/bitwarden/android/commit/3191ff86de3a73d9e7b4d359eae039393c7b24e0) Add input for cutting RC branch ### 📊 Changes **2 files changed** (+42 additions, -8 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/_cut_rc.yml` (+29 -0) 📝 `.github/workflows/version-bump.yml` (+13 -8) </details> ### 📄 Description ## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR updates how we bump version numbers and cut the `rc` branch. The new procedure is outlined below. If you have more than one project to cut `rc` for: - Go to the `DevOps` repository and run the `RC Branch Manager` workflow with the following inputs. - `cut`mode. - Desired projects checked. - `Version Number` filled out. You can also just run the `Version Bump` workflow in the repository by itself if you don't need to cut `rc` for multiple projects. The following will take place: - The version number is verified. - The `Version Bump` workflow in the each repository is called via the GitHub CLI. - The version will be bumped, committed to a branch, PR created, PR approved, PR merged. - The `Cut RC Branch` workflow will run to create and push the `rc` branch. - A Slack message will be sent to notify of the PR. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **.github/workflows/_cut_rc.yml:** Added to help cut the `rc` branch. * **.github/workflows/version-bump.yml:** Removed `workflow_call` trigger as it's no longer needed. Added input for cutting the `rc` branch. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - If making database changes - make sure you also update Entity Framework queries and/or migrations - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:33:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#10022
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?