github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

PM-24539: Prevent token refresh from looping (#5658)

Browse Source
This commit is contained in:
David Perez
2025-08-07 08:53:56 -05:00
committed by GitHub
parent 3c033d4aa2
commit fc88ca1ba8
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
network/src/main/kotlin/com/bitwarden/network/authenticator/RefreshAuthenticator.kt
View File

@@ -8,6 +8,7 @@ import okhttp3.Authenticator
import okhttp3.Request
import okhttp3.Response
import okhttp3.Route
import timber.log.Timber
/**
* An authenticator used to refresh the access token when a 401 is returned from an API. Upon
@@ -21,6 +22,10 @@ internal class RefreshAuthenticator : Authenticator {
route: Route?,
response: Response,
): Request? {
if (response.shouldSkipAuthentication()) {
// If the same request keeps failing, let's just let the 401 pass through.
return null
}
val accessToken = requireNotNull(
response
.request
@@ -34,6 +39,7 @@ internal class RefreshAuthenticator : Authenticator {
}
else -> {
Timber.d("Attempting to refresh token due to unauthorized")
refreshTokenProvider
?.refreshAccessTokenSynchronously(userId = userId)
?.fold(
@@ -52,4 +58,6 @@ internal class RefreshAuthenticator : Authenticator {
}
}
}
private fun Response.shouldSkipAuthentication(): Boolean = this.priorResponse != null
}