mirror of
https://github.com/bitwarden/android.git
synced 2026-11-19 17:40:12 -06:00
BIT-1259: Fix for Increasing Length Creates a Password in History for Each Adjustment (#427)
This commit is contained in:
committed by
Álison Fernandes
parent
3fd93b2589
commit
f9667d0390
+49
-3
@@ -71,8 +71,9 @@ class GeneratorRepositoryTest {
|
||||
unmockkStatic(Instant::class)
|
||||
}
|
||||
|
||||
@Suppress("MaxLineLength")
|
||||
@Test
|
||||
fun `generatePassword should emit Success result and store the generated password`() = runTest {
|
||||
fun `generatePassword should emit Success result and store the generated password when shouldSave is true`() = runTest {
|
||||
val fixedInstant = Instant.parse("2021-01-01T00:00:00Z")
|
||||
|
||||
mockkStatic(Instant::class)
|
||||
@@ -105,7 +106,7 @@ class GeneratorRepositoryTest {
|
||||
|
||||
coEvery { passwordHistoryDiskSource.insertPasswordHistory(any()) } just runs
|
||||
|
||||
val result = repository.generatePassword(request)
|
||||
val result = repository.generatePassword(request, true)
|
||||
|
||||
assertEquals(generatedPassword, (result as GeneratedPasswordResult.Success).generatedString)
|
||||
coVerify { generatorSdkSource.generatePassword(request) }
|
||||
@@ -117,6 +118,51 @@ class GeneratorRepositoryTest {
|
||||
}
|
||||
}
|
||||
|
||||
@Suppress("MaxLineLength")
|
||||
@Test
|
||||
fun `generatePassword should emit Success result but not store the generated password when shouldSave is false`() = runTest {
|
||||
val fixedInstant = Instant.parse("2021-01-01T00:00:00Z")
|
||||
|
||||
mockkStatic(Instant::class)
|
||||
every { Instant.now() } returns fixedInstant
|
||||
|
||||
val userId = "testUserId"
|
||||
val request = PasswordGeneratorRequest(
|
||||
lowercase = true,
|
||||
uppercase = true,
|
||||
numbers = true,
|
||||
special = true,
|
||||
length = 12.toUByte(),
|
||||
avoidAmbiguous = false,
|
||||
minLowercase = null,
|
||||
minUppercase = null,
|
||||
minNumber = null,
|
||||
minSpecial = null,
|
||||
)
|
||||
val generatedPassword = "GeneratedPassword123!"
|
||||
val encryptedPasswordHistory =
|
||||
PasswordHistory(password = generatedPassword, lastUsedDate = Instant.now())
|
||||
|
||||
coEvery { authDiskSource.userState?.activeUserId } returns userId
|
||||
|
||||
coEvery { generatorSdkSource.generatePassword(request) } returns
|
||||
Result.success(generatedPassword)
|
||||
|
||||
coEvery { vaultSdkSource.encryptPasswordHistory(any()) } returns
|
||||
Result.success(encryptedPasswordHistory)
|
||||
|
||||
coEvery { passwordHistoryDiskSource.insertPasswordHistory(any()) } just runs
|
||||
|
||||
val result = repository.generatePassword(request, false)
|
||||
|
||||
assertEquals(generatedPassword, (result as GeneratedPasswordResult.Success).generatedString)
|
||||
coVerify { generatorSdkSource.generatePassword(request) }
|
||||
|
||||
coVerify(exactly = 0) {
|
||||
passwordHistoryDiskSource.insertPasswordHistory(any())
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `generatePassword should emit InvalidRequest result when SDK throws exception`() = runTest {
|
||||
val request = PasswordGeneratorRequest(
|
||||
@@ -134,7 +180,7 @@ class GeneratorRepositoryTest {
|
||||
val exception = RuntimeException("An error occurred")
|
||||
coEvery { generatorSdkSource.generatePassword(request) } returns Result.failure(exception)
|
||||
|
||||
val result = repository.generatePassword(request)
|
||||
val result = repository.generatePassword(request, true)
|
||||
|
||||
assertTrue(result is GeneratedPasswordResult.InvalidRequest)
|
||||
coVerify { generatorSdkSource.generatePassword(request) }
|
||||
|
||||
+1
@@ -33,6 +33,7 @@ class FakeGeneratorRepository : GeneratorRepository {
|
||||
|
||||
override suspend fun generatePassword(
|
||||
passwordGeneratorRequest: PasswordGeneratorRequest,
|
||||
shouldSave: Boolean,
|
||||
): GeneratedPasswordResult {
|
||||
return generatePasswordResult
|
||||
}
|
||||
|
||||
+10
@@ -288,6 +288,16 @@ class GeneratorScreenTest : BaseComposeTest() {
|
||||
viewModel.trySendAction(
|
||||
GeneratorAction.MainType.Passcode.PasscodeType.Password.SliderLengthChange(
|
||||
length = 128,
|
||||
isUserInteracting = true,
|
||||
),
|
||||
)
|
||||
}
|
||||
|
||||
verify {
|
||||
viewModel.trySendAction(
|
||||
GeneratorAction.MainType.Passcode.PasscodeType.Password.SliderLengthChange(
|
||||
length = 128,
|
||||
isUserInteracting = false,
|
||||
),
|
||||
)
|
||||
}
|
||||
|
||||
+1
@@ -409,6 +409,7 @@ class GeneratorViewModelTest : BaseViewModelTest() {
|
||||
viewModel.actionChannel.trySend(
|
||||
GeneratorAction.MainType.Passcode.PasscodeType.Password.SliderLengthChange(
|
||||
length = newLength,
|
||||
isUserInteracting = false,
|
||||
),
|
||||
)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user