From f2eb524da436224a701d61733780baed08dd7a8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Bispo?= Date: Tue, 18 Feb 2025 20:07:45 +0000 Subject: [PATCH] [PM-18281] Change cipher key encryption flag default value to false (#4742) --- .../com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt | 2 +- .../bitwarden/data/platform/manager/FeatureFlagManagerTest.kt | 2 +- .../com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt b/app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt index 2cded9a520..0a8f529ab3 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt @@ -145,7 +145,7 @@ sealed class FlagKey { */ data object CipherKeyEncryption : FlagKey() { override val keyName: String = "cipher-key-encryption" - override val defaultValue: Boolean = true + override val defaultValue: Boolean = false override val isRemotelyConfigured: Boolean = true } diff --git a/app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt b/app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt index 1c7a6f70dc..66040b9efb 100644 --- a/app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt +++ b/app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt @@ -27,7 +27,7 @@ class FeatureFlagManagerTest { @Test fun `sdkFeatureFlags should return set feature flags`() { - val expected = mapOf("enableCipherKeyEncryption" to true) + val expected = mapOf("enableCipherKeyEncryption" to false) val actual = manager.sdkFeatureFlags diff --git a/app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt b/app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt index 79e144aab5..d6367b3ab2 100644 --- a/app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt +++ b/app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt @@ -103,12 +103,11 @@ class FlagKeyTest { FlagKey.SingleTapPasskeyAuthentication, FlagKey.AnonAddySelfHostAlias, FlagKey.SimpleLoginSelfHostAlias, + FlagKey.CipherKeyEncryption, ).all { !it.defaultValue }, ) - - assertTrue(FlagKey.CipherKeyEncryption.defaultValue) } @Test