BIT-2145: Create account dialog error (#1243)

This commit is contained in:
Ramsey Smith
2024-06-20 17:08:07 +01:00
committed by Álison Fernandes
parent 0a63d85457
commit f01a67ea9c
9 changed files with 263 additions and 30 deletions
@@ -2910,25 +2910,64 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.Success(CAPTCHA_KEY), result)
}
@Test
fun `register check data breaches found should return DataBreachFound`() = runTest {
coEvery {
haveIBeenPwnedService.hasPasswordBeenBreached(PASSWORD)
} returns true.asSuccess()
fun `register check data breaches found and strong password should return DataBreachFound`() =
runTest {
coEvery {
haveIBeenPwnedService.hasPasswordBeenBreached(PASSWORD)
} returns true.asSuccess()
val result = repository.register(
email = EMAIL,
masterPassword = PASSWORD,
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
)
assertEquals(RegisterResult.DataBreachFound, result)
}
val result = repository.register(
email = EMAIL,
masterPassword = PASSWORD,
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.DataBreachFound, result)
}
@Test
fun `register check data breaches and weak password should return DataBreachAndWeakPassword`() =
runTest {
coEvery {
haveIBeenPwnedService.hasPasswordBeenBreached(PASSWORD)
} returns true.asSuccess()
val result = repository.register(
email = EMAIL,
masterPassword = PASSWORD,
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
isMasterPasswordStrong = false,
)
assertEquals(RegisterResult.DataBreachAndWeakPassword, result)
}
@Test
fun `register check no data breaches found with weak password should return WeakPassword`() =
runTest {
coEvery {
haveIBeenPwnedService.hasPasswordBeenBreached(PASSWORD)
} returns false.asSuccess()
val result = repository.register(
email = EMAIL,
masterPassword = PASSWORD,
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
isMasterPasswordStrong = false,
)
assertEquals(RegisterResult.WeakPassword, result)
}
@Test
fun `register check data breaches Success should return Success`() = runTest {
@@ -2959,6 +2998,7 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.Success(CAPTCHA_KEY), result)
coVerify { haveIBeenPwnedService.hasPasswordBeenBreached(PASSWORD) }
@@ -2991,6 +3031,7 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.Success(CAPTCHA_KEY), result)
}
@@ -3031,6 +3072,7 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.Error(errorMessage = null), result)
}
@@ -3071,6 +3113,7 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.CaptchaRequired(captchaId = CAPTCHA_KEY), result)
}
@@ -3102,6 +3145,7 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.Error(errorMessage = null), result)
}
@@ -3133,6 +3177,7 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.Error(errorMessage = "message"), result)
}
@@ -3169,6 +3214,7 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.Error(errorMessage = "expected"), result)
}
@@ -3200,6 +3246,7 @@ class AuthRepositoryTest {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
assertEquals(RegisterResult.Error(errorMessage = "message"), result)
}
@@ -198,7 +198,7 @@ class CreateAccountScreenTest : BaseComposeTest() {
@Test
fun `clicking No on the HIBP dialog should send ErrorDialogDismiss action`() {
mutableStateFlow.update {
it.copy(dialog = CreateAccountDialog.HaveIBeenPwned)
it.copy(dialog = createHaveIBeenPwned())
}
composeTestRule
.onAllNodesWithText("No")
@@ -210,7 +210,7 @@ class CreateAccountScreenTest : BaseComposeTest() {
@Test
fun `clicking Yes on the HIBP dialog should send ContinueWithBreachedPasswordClick action`() {
mutableStateFlow.update {
it.copy(dialog = CreateAccountDialog.HaveIBeenPwned)
it.copy(dialog = createHaveIBeenPwned())
}
composeTestRule
.onAllNodesWithText("Yes")
@@ -0,0 +1,18 @@
package com.x8bit.bitwarden.ui.auth.feature.createaccount
import com.x8bit.bitwarden.R
import com.x8bit.bitwarden.ui.platform.base.util.Text
import com.x8bit.bitwarden.ui.platform.base.util.asText
/**
* Creates a mock [CreateAccountDialog.HaveIBeenPwned].
*/
fun createHaveIBeenPwned(
title: Text = R.string.weak_and_exposed_master_password.asText(),
message: Text = R.string.weak_password_identified_and_found_in_a_data_breach_alert_description
.asText(),
): CreateAccountDialog.HaveIBeenPwned =
CreateAccountDialog.HaveIBeenPwned(
title = title,
message = message,
)
@@ -30,6 +30,7 @@ import io.mockk.every
import io.mockk.mockk
import io.mockk.mockkStatic
import io.mockk.unmockkStatic
import kotlinx.coroutines.flow.emptyFlow
import kotlinx.coroutines.flow.flowOf
import kotlinx.coroutines.test.runTest
import org.junit.jupiter.api.AfterEach
@@ -37,6 +38,7 @@ import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Test
@Suppress("LargeClass")
class CreateAccountViewModelTest : BaseViewModelTest() {
/**
@@ -232,6 +234,7 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
} returns RegisterResult.Success(captchaToken = "mock_token")
}
@@ -271,6 +274,7 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
} returns RegisterResult.Error(errorMessage = "mock_error")
}
@@ -314,6 +318,7 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
} returns RegisterResult.CaptchaRequired(captchaId = "mock_captcha_id")
}
@@ -345,6 +350,7 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
} returns RegisterResult.Success(captchaToken = "mock_captcha_token")
}
@@ -375,6 +381,7 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
} returns RegisterResult.Error(null)
}
@@ -390,6 +397,7 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = false,
isMasterPasswordStrong = true,
)
}
}
@@ -397,7 +405,7 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
@Test
fun `SubmitClick register returns ShowDataBreaches should show HaveIBeenPwned dialog`() =
runTest {
val repo = mockk<AuthRepository> {
mockAuthRepository.apply {
every { captchaTokenResultFlow } returns flowOf()
coEvery {
register(
@@ -406,20 +414,92 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
isMasterPasswordStrong = true,
)
} returns RegisterResult.DataBreachFound
}
val viewModel = CreateAccountViewModel(
savedStateHandle = validInputHandle,
authRepository = repo,
val initialState = VALID_INPUT_STATE.copy(
isCheckDataBreachesToggled = true,
)
viewModel.trySendAction(CreateAccountAction.CheckDataBreachesToggle(true))
val viewModel = createCreateAccountViewModel(createAccountState = initialState)
viewModel.trySendAction(CreateAccountAction.SubmitClick)
viewModel.stateFlow.test {
assertEquals(
VALID_INPUT_STATE.copy(
isCheckDataBreachesToggled = true,
dialog = CreateAccountDialog.HaveIBeenPwned,
initialState.copy(
dialog = createHaveIBeenPwned(
title = R.string.exposed_master_password.asText(),
message = R.string.password_found_in_a_data_breach_alert_description
.asText(),
),
),
awaitItem(),
)
}
}
@Test
@Suppress("MaxLineLength")
fun `SubmitClick register returns DataBreachAndWeakPassword should show HaveIBeenPwned dialog`() =
runTest {
mockAuthRepository.apply {
every { captchaTokenResultFlow } returns emptyFlow()
coEvery {
register(
email = EMAIL,
masterPassword = PASSWORD,
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
isMasterPasswordStrong = false,
)
} returns RegisterResult.DataBreachAndWeakPassword
}
val initialState = VALID_INPUT_STATE.copy(
passwordStrengthState = PasswordStrengthState.WEAK_1,
isCheckDataBreachesToggled = true,
)
val viewModel = createCreateAccountViewModel(createAccountState = initialState)
viewModel.trySendAction(CreateAccountAction.SubmitClick)
viewModel.stateFlow.test {
assertEquals(
initialState.copy(dialog = createHaveIBeenPwned()),
awaitItem(),
)
}
}
@Test
@Suppress("MaxLineLength")
fun `SubmitClick register returns WeakPassword should show HaveIBeenPwned dialog`() =
runTest {
mockAuthRepository.apply {
every { captchaTokenResultFlow } returns flowOf()
coEvery {
register(
email = EMAIL,
masterPassword = PASSWORD,
masterPasswordHint = null,
captchaToken = null,
shouldCheckDataBreaches = true,
isMasterPasswordStrong = false,
)
} returns RegisterResult.WeakPassword
}
val initialState = VALID_INPUT_STATE
.copy(
passwordStrengthState = PasswordStrengthState.WEAK_1,
isCheckDataBreachesToggled = true,
)
val viewModel = createCreateAccountViewModel(createAccountState = initialState)
viewModel.trySendAction(CreateAccountAction.SubmitClick)
viewModel.stateFlow.test {
assertEquals(
initialState.copy(
dialog = createHaveIBeenPwned(
title = R.string.weak_master_password.asText(),
message = R.string.weak_password_identified_use_a_strong_password_to_protect_your_account.asText(),
),
),
awaitItem(),
)
@@ -604,6 +684,15 @@ class CreateAccountViewModelTest : BaseViewModelTest() {
}
}
private fun createCreateAccountViewModel(
createAccountState: CreateAccountState? = null,
authRepository: AuthRepository = mockAuthRepository,
): CreateAccountViewModel =
CreateAccountViewModel(
savedStateHandle = SavedStateHandle(mapOf("state" to createAccountState)),
authRepository = authRepository,
)
companion object {
private const val PASSWORD = "longenoughtpassword"
private const val EMAIL = "test@test.com"